837ffcfab5
all: Fix various user-facing and non-user-facing typos ( #8509 )
...
Found via `codespell -q 3 -S lang,./gui/default/vendor -L benchs,bu,inflight,ro`
2022-08-23 15:44:11 +02:00
b10d106a55
all: Modernize error wrapping ( #8491 )
...
This replaces old style errors.Wrap with modern fmt.Errorf and removes
the (direct) dependency on github.com/pkg/errors. A couple of cases are
adjusted by hand as previously errors.Wrap(nil, ...) would return nil,
which is not what fmt.Errorf does.
2022-08-16 10:01:49 +02:00
4d4bfe8032
lib/model: Skip paused folders in aggregated completion loop ( fixes #8219 ) ( #8220 )
...
Locally paused folders will fail on checkFolderRunningLocked() and
therefore abort the loop. Avoid this by skipping paused folders
directly.
Co-authored-by: Jakob Borg <jakob@kastelo.net>
2022-08-10 08:50:19 +02:00
a3c724f2c3
all: Add build constants for runtime.GOOS comparisons ( #8442 )
...
all: Add package runtimeos for runtime.GOOS comparisons
I grew tired of hand written string comparisons. This adds generated
constants for the GOOS values, and predefined Is$OS constants that can
be iffed on. In a couple of places I rewrote trivial switch:es to if:s,
and added Illumos where we checked for Solaris (because they are
effectively the same, and if we're going to target one of them that
would be Illumos...).
2022-07-28 19:36:39 +02:00
dde275c6cc
all: Unused errors
2022-07-28 19:08:51 +02:00
755d21953f
all: Remove unused method receivers ( #8462 )
...
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2022-07-28 17:32:45 +02:00
5130c414da
all: Unused parameter should be replaced by underscore ( #8464 )
...
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2022-07-28 17:17:29 +02:00
0bdd0d595b
lib/model: Replace `for` loop with `append` ( #8457 )
...
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2022-07-28 16:57:09 +02:00
80ec4acb53
all: Fix check for empty string ( #8456 )
...
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2022-07-28 16:51:03 +02:00
a6dba7c6d6
lib/model, lib/config: Apply sensible defaults for auto-accepted encrypted folder ( fixes #8296 ) ( #8427 )
...
* lib/model: Override scan config for auto-accepted encrypted folders.
Encrypted folders should not have the fs watcher enabled and rarely
benefit from a scheduled rescan. The GUI adjusts the suggested
settings (watcher disabled, one day rescan interval) when accepting a
receive-encrypted folder. Mirror that behavior to the auto-accept
case where the GUI is not involved.
Versioning also does not work well for encrypted folders, same
treatment.
2022-07-22 11:27:58 +02:00
3a6ebb8482
lib/config, lib/model: Warn about two-way introducer ( fixes #8393 ) ( #8395 )
2022-06-20 18:36:45 +01:00
1eda82b95f
lib/model: Improve remoteFolderState reporting ( fixes #8266 ) ( #8283 )
2022-04-22 08:42:20 +02:00
0c46e0a9cc
gui, lib/model: Mark folders unaccepted by remote device ( fixes #8202 ) ( #8201 )
2022-04-10 22:47:57 +02:00
db72579f0e
lib: Get rid of buggy filesystem wrapping ( #8257 )
2022-04-10 20:55:05 +02:00
072fa46bfd
lib/connections, lib/model: Improve new conn handling ( #8253 )
2022-04-07 17:35:33 +02:00
1c74944cca
lib/api: Fix comments for endpoint parameters ( #8163 )
2022-02-07 08:51:09 +01:00
635085d139
lib/db, lib/model: Remove filesystem state from FileSet ( fixes #7850 ) ( #8151 )
2022-01-31 10:12:52 +01:00
21d04b895a
lib, gui: Default ignores for new folders ( fixes #7428 ) ( #7530 )
2022-01-13 23:38:21 +01:00
0cba3154f0
lib/model: Remove bogus fields from connections API endpoint ( fixes #8103 ) ( #8104 )
...
* lib/model: Remove bogus fields from connections API endpoint.
Switch the returned data type for the /rest/system/connections element
"total" to use only the Statistics struct. The other fields of the
ConnectionInfo struct are not populated and misleading.
* Lowercase JSON field names.
* lib/model: Get rid of ConnectionInfo.MarshalJSON().
It was missing the StartedAt field from the embedded Statistics
struct. Just lowercasing the JSON attribute names can be done just as
easily with annotations.
* lib/model: Remove bogus startedAt field from totals.
Instead of using the Statistics type with one field empty, just switch
to a free-form map with the three needed fields.
2022-01-10 10:26:45 +01:00
bf89bffb0b
lib/config: Decouple VerifyConfiguration from Committer ( #7939 )
...
... and remove 8/10 implementations, which were no-ops. This saves code
and time copying configurations.
2021-11-22 08:45:29 +01:00
591e4d8af1
gui, lib: Fix tracking deleted locally-changed on encrypted ( fixes #7715 ) ( #7726 )
2021-11-10 09:46:21 +01:00
296cc1bca2
lib/model: Limit the number of default hashers on Android (ref #2220 )
...
Like Windows and Mac, Android is also an interactive operating system.
On top of that, it usually runs on much slower hardware than the other
two. Because of that, it makes sense to limit the number of hashes used
by default there too.
Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
2021-10-29 10:06:52 +02:00
721cd740d8
lib/model: Don't reset db while folder is running ( fixes #7935 ) ( #7936 )
2021-09-11 17:14:47 +02:00
0ffa7f3f57
all: Clarify 'Cleaning data for folder' log message ( #7937 )
...
Instead of data (could be read as user data), use metadata.
2021-09-10 09:56:44 +02:00
4e2a9bb139
lib/model: Remove encryption pw on folder stop ( #7925 )
2021-09-03 09:54:47 +02:00
c025e76f30
lib/model: Do not wait for scan when setting ignores ( fixes #7893 ) ( #7891 )
2021-08-17 09:23:33 +02:00
67b18569cf
all: Send deadlocks as failures, crash only as a last resort ( #7785 )
2021-07-27 21:27:52 +02:00
eeb7091180
lib/model: Missing fmut-lock on encryption failures ( #7841 )
2021-07-22 11:15:25 +02:00
89e762fd6e
lib/model: Prevent folder-type change from/to encrypted ( fixes #7704 ) ( #7796 )
2021-07-03 13:47:04 +02:00
c78fa42f31
lib/connections: Dial devices in parallel ( #7783 )
2021-06-25 11:38:04 +02:00
ac2988a485
gui, lib: Handle pw adding remote encrypted folder ( fixes #7705 ) ( #7772 )
2021-06-17 13:53:02 +02:00
1e7a3997e3
lib/db, lib/model: Improve error handling on pending items ( #7754 )
2021-06-09 13:35:17 +02:00
45edad867c
all: Allow dismissing pending devices / folders without ignoring ( fixes #7700 ) ( #7712 )
2021-06-07 10:29:24 +02:00
b1e0e7b923
lib/model: Fix indexhandling for new folders paused on remote ( #7747 )
2021-06-05 16:27:15 +02:00
41baccb85d
lib/model: Fix passwords on receive-enc needing token (ref #7518 ) ( #7739 )
2021-06-03 15:39:49 +02:00
004eded398
lib/model: Don't share with introduced device if encrypted ( fixes #7724 ) ( #7734 )
2021-06-03 15:02:57 +02:00
df48276300
lib/model: Ensure indexes are only received after checking IDs (ref #7649 ) ( #7689 )
2021-06-03 14:58:50 +02:00
fcb19518c7
build, lib/model: Add flag to run tests without -short and fix failure ( #7716 )
2021-05-28 22:20:18 +02:00
22e09334ec
lib/model: Fix incoming request on receive-enc ( fixes #7699 ) ( #7702 )
2021-05-22 21:38:49 +02:00
0d054f9b64
lib/model: Don't use empty folder cfg for index sender ( fixes #7649 ) ( #7671 )
2021-05-15 11:13:39 +02:00
5cb2a10138
lib/model: Improve encryption cluster-config errors ( #7658 )
2021-05-11 07:55:44 +02:00
3746c899b7
build: List go:generate tools in tools.go ( #7599 )
2021-05-08 12:52:06 +02:00
87a0eecc31
lib/fs, lib/api, lib/model: Expose mtime remappings as part of /db/file ( #7624 )
...
* lib/fs, lib/api, lib/model: Expose mtime remappings as part of /db/file
* Fix wrong error returned by CLI
* Gofmt
* Better names
* Review comments
* Review comments
2021-05-03 11:28:25 +01:00
dd39556759
lib: Revert needing invalid files ( fixes #7608 , ref #7476 ) ( #7609 )
2021-04-29 22:01:46 +02:00
1f30383866
lib/model: Remove path from enc errors and report only once ( #7610 )
2021-04-29 19:21:07 +02:00
e4c995a321
lib/model: Don't remove non-empty .stfolder ( #7578 )
2021-04-15 18:13:35 +02:00
ec0a66c75b
lib/db, lib/model: Refactor removing expired pending folders ( #7537 )
2021-04-11 15:24:08 +02:00
0d7a77ba85
lib/model: Reset conn when enc token is missing ( fixes #7198 ) ( #7518 )
2021-03-23 10:38:40 +01:00
924b96856f
lib: Handle adding enc folders on an existing conn ( fixes #7509 ) ( #7510 )
2021-03-22 21:50:19 +01:00
8ef504f745
all: Simplify some method calls ( #7499 )
...
strings.Replace(a, b, c, -1) -> strings.ReplaceAll(a, b, c)
(Go 1.12) and who knows what was up with that dialQueue.Sort() thing.
2021-03-17 23:12:26 +01:00
luzpaz
Jakob Borg
André Colomb
deepsource-autofix[bot]
Simon Frei
greatroar
Tomasz Wilczyński
jtagcat
Audrius Butkevicius