Martchus
/
syncthingtray
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't call recalculateStatus() in emitNotifications() 

because notifications have nothing to do with the status and it should not
make a difference since the status would not change. The UI is supposed to
rely only on newNotification().
This commit is contained in:
Martchus 2020-12-31 02:28:11 +01:00
parent b8f3b664e0
commit 41e0934cd8
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
connector/syncthingconnection.cpp
View File

@ -851,17 +851,6 @@ void SyncthingConnection::setStatus(SyncthingStatus status)
}
}
/*!
* \brief Interanlly called to emit the notification with the specified \a message.
* \remarks Ensures the status is updated and the unread notifications flag is set.
*/
void SyncthingConnection::emitNotification(DateTime when, const QString &message)
{
m_unreadNotifications = true;
emit newNotification(when, message);
recalculateStatus();
}
/*!
* \brief Internally called to emit a JSON parsing error.
* \remarks Since in this case the reply has already been read, its response must be passed as extra argument.

10
connector/syncthingconnection.h
View File

@ -488,6 +488,16 @@ inline void SyncthingConnection::setRequestingCompletionEnabled(bool requestingC
m_requestCompletion = requestingCompletionEnabled;
}
/*!
* \brief Interanlly called to emit the notification with the specified \a message.
* \remarks Ensures the unread notifications flag is set.
*/
inline void SyncthingConnection::emitNotification(CppUtilities::DateTime when, const QString &message)
{
m_unreadNotifications = true;
emit newNotification(when, message);
}
/*!
* \brief Considers all notifications as read; hence might trigger a status update.
*/