Martchus
/
syncthingtray
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve coding style in SyncthingConnectionSettings::loadHttpsCert()

This commit is contained in:
Martchus 2018-03-29 00:36:42 +02:00
parent 419e2971c1
commit e6642245df
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
connector/syncthingconnectionsettings.cpp
View File

@ -5,17 +5,22 @@ namespace Data {
bool SyncthingConnectionSettings::loadHttpsCert()
{
expectedSslErrors.clear();
if (!httpsCertPath.isEmpty()) {
const QList<QSslCertificate> cert = QSslCertificate::fromPath(httpsCertPath);
if (cert.isEmpty()) {
return false;
}
expectedSslErrors.reserve(4);
expectedSslErrors << QSslError(QSslError::UnableToGetLocalIssuerCertificate, cert.at(0));
expectedSslErrors << QSslError(QSslError::UnableToVerifyFirstCertificate, cert.at(0));
expectedSslErrors << QSslError(QSslError::SelfSignedCertificate, cert.at(0));
expectedSslErrors << QSslError(QSslError::HostNameMismatch, cert.at(0));
if (httpsCertPath.isEmpty()) {
return true;
}
const auto certs(QSslCertificate::fromPath(httpsCertPath));
if (certs.isEmpty()) {
return false;
}
const auto &cert(certs.front());
// clang-format off
expectedSslErrors = {
QSslError(QSslError::UnableToGetLocalIssuerCertificate, cert),
QSslError(QSslError::UnableToVerifyFirstCertificate, cert),
QSslError(QSslError::SelfSignedCertificate, cert),
QSslError(QSslError::HostNameMismatch, cert)
};
// clang-format on
return true;
}
} // namespace Data