Martchus
/
tageditor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Do not allow changing tag target of Ogg Vorbis comments 

It has no effect anyways as tagparser does not allow to move a Vorbis
comment from one stream to another this way.
This commit is contained in:
Martchus 2022-05-03 23:54:46 +02:00
parent 5150a61d47
commit 25458a0ca7
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gui/tageditorwidget.cpp
View File

@ -590,7 +590,8 @@ void TagEditorWidget::updateTagManagementMenu()
// add "Remove tag" and "Change target" actions
for (Tag *tag : m_tags) {
// don't propose removal for Vorbis comments from Voribs or FLAC streams (removing from Opus streams should be ok)
if (tag->type() == TagType::OggVorbisComment) {
const auto tagType = tag->type();
if (tagType == TagType::OggVorbisComment) {
switch (static_cast<OggVorbisComment *>(tag)->oggParams().streamFormat) {
case GeneralMediaFormat::Vorbis:
case GeneralMediaFormat::Flac:
@ -601,7 +602,7 @@ void TagEditorWidget::updateTagManagementMenu()
connect(m_removeTagMenu->addAction(QString::fromUtf8(tag->toString().c_str())), &QAction::triggered,
std::bind(&TagEditorWidget::removeTag, this, tag));
if (tag->supportsTarget()) {
if (tagType != TagType::OggVorbisComment && tag->supportsTarget()) {
connect(m_changeTargetMenu->addAction(QString::fromUtf8(tag->toString().c_str())), &QAction::triggered,
std::bind(&TagEditorWidget::changeTarget, this, tag));
}