Martchus
/
tagparser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't consider UTF-8 an encoding which can be used in ID3v1 

UTF-8 within ID3v1 is still supported relying on the presence of
the BOM. However, the library should not advise that to tag editing
clients.
This commit is contained in:
Martchus 2019-06-14 18:07:59 +02:00
parent c9e1dde70b
commit 9a5c78b725
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
id3/id3v1tag.cpp
View File

@ -37,9 +37,17 @@ const char *Id3v1Tag::typeName() const
return tagName;
}
/*!
* \brief Returns only true for TagTextEncoding::Latin1.
* \remarks
* The encoding to be used within ID3v1 tags is not standardized but it seems that Latin-1 is the most
* commonly used character set and hence safest to use. Hence that is the only encoding which can be safely
* recommended here. Despite that, the Id3v1Tag class is actually able to deal with UTF-8 as well. It will
* use the BOM to detect and serialize UTF-8.
*/
bool Id3v1Tag::canEncodingBeUsed(TagTextEncoding encoding) const
{
return encoding == TagTextEncoding::Latin1 || encoding == TagTextEncoding::Utf8;
return encoding == TagTextEncoding::Latin1;
}
/*!