From ee09a509155858706ce778264bb2ed364b0df40d Mon Sep 17 00:00:00 2001 From: Martchus Date: Mon, 21 Dec 2015 18:35:47 +0100 Subject: [PATCH] removed useless destructors --- fieldbasedtag.h | 8 -------- id3/id3v1tag.cpp | 6 ------ id3/id3v1tag.h | 1 - id3/id3v2tag.h | 7 ------- matroska/matroskatag.h | 13 ------------- mp4/mp4tag.h | 7 ------- vorbis/vorbiscomment.h | 7 ------- 7 files changed, 49 deletions(-) diff --git a/fieldbasedtag.h b/fieldbasedtag.h index 3d17054..9d1a95f 100644 --- a/fieldbasedtag.h +++ b/fieldbasedtag.h @@ -26,7 +26,6 @@ class FieldMapBasedTag : public Tag { public: FieldMapBasedTag(); - virtual ~FieldMapBasedTag(); virtual const TagValue &value(KnownField field) const; virtual const TagValue &value(const typename FieldType::identifierType &id) const; @@ -73,13 +72,6 @@ template FieldMapBasedTag::FieldMapBasedTag() {} -/*! - * \brief Destroys the tag. - */ -template -FieldMapBasedTag::~FieldMapBasedTag() -{} - template inline const TagValue &FieldMapBasedTag::value(KnownField field) const { diff --git a/id3/id3v1tag.cpp b/id3/id3v1tag.cpp index 1df714f..43b8e07 100644 --- a/id3/id3v1tag.cpp +++ b/id3/id3v1tag.cpp @@ -23,12 +23,6 @@ namespace Media { Id3v1Tag::Id3v1Tag() {} -/*! - * \brief Destroys the tag. - */ -Id3v1Tag::~Id3v1Tag() -{} - TagType Id3v1Tag::type() const { return TagType::Id3v1Tag; diff --git a/id3/id3v1tag.h b/id3/id3v1tag.h index 742fa70..4e00305 100644 --- a/id3/id3v1tag.h +++ b/id3/id3v1tag.h @@ -10,7 +10,6 @@ class LIB_EXPORT Id3v1Tag : public Tag { public: Id3v1Tag(); - virtual ~Id3v1Tag(); virtual TagType type() const; virtual const char *typeName() const; diff --git a/id3/id3v2tag.h b/id3/id3v2tag.h index 36c4ed6..b208f97 100644 --- a/id3/id3v2tag.h +++ b/id3/id3v2tag.h @@ -19,7 +19,6 @@ class LIB_EXPORT Id3v2Tag : public FieldMapBasedTag { public: Id3v2Tag(); - ~Id3v2Tag(); TagType type() const; const char *typeName() const; @@ -71,12 +70,6 @@ inline Id3v2Tag::Id3v2Tag() : m_paddingSize(0) {} -/*! - * \brief Destroys the tag. - */ -inline Id3v2Tag::~Id3v2Tag() -{} - inline TagType Id3v2Tag::type() const { return TagType::Id3v2Tag; diff --git a/matroska/matroskatag.h b/matroska/matroskatag.h index 116d151..cec68af 100644 --- a/matroska/matroskatag.h +++ b/matroska/matroskatag.h @@ -50,14 +50,12 @@ class LIB_EXPORT MatroskaTag : public FieldMapBasedTag { public: MatroskaTag(); - ~MatroskaTag(); TagType type() const; const char *typeName() const; TagTextEncoding proposedTextEncoding() const; bool canEncodingBeUsed(TagTextEncoding encoding) const; bool supportsTarget() const; -// bool supportsNestedTags() const; std::string fieldId(KnownField field) const; KnownField knownField(const std::string &id) const; @@ -75,23 +73,12 @@ inline bool MatroskaTag::supportsTarget() const return true; } -//inline bool MatroskaTag::supportsNestedTags() const -//{ -// return true; -//} - /*! * \brief Constructs a new tag. */ inline MatroskaTag::MatroskaTag() {} -/*! - * \brief Destroys the tag. - */ -inline MatroskaTag::~MatroskaTag() -{} - inline TagType MatroskaTag::type() const { return TagType::MatroskaTag; diff --git a/mp4/mp4tag.h b/mp4/mp4tag.h index c3b2445..fe02cde 100644 --- a/mp4/mp4tag.h +++ b/mp4/mp4tag.h @@ -50,7 +50,6 @@ class LIB_EXPORT Mp4Tag : public FieldMapBasedTag { public: Mp4Tag(); - ~Mp4Tag(); TagType type() const; const char *typeName() const; @@ -79,12 +78,6 @@ public: inline Mp4Tag::Mp4Tag() {} -/*! - * \brief Destroys the tag. - */ -inline Mp4Tag::~Mp4Tag() -{} - inline TagType Mp4Tag::type() const { return TagType::Mp4Tag; diff --git a/vorbis/vorbiscomment.h b/vorbis/vorbiscomment.h index 4944b4e..3ac0bb5 100644 --- a/vorbis/vorbiscomment.h +++ b/vorbis/vorbiscomment.h @@ -14,7 +14,6 @@ class LIB_EXPORT VorbisComment : public FieldMapBasedTag