From 24e2ec0136bc18e3b02ec16d8c4087ce7be38104 Mon Sep 17 00:00:00 2001
From: Martchus <martchus@gmx.net>
Date: Wed, 22 Nov 2023 21:50:45 +0100
Subject: [PATCH] Fix reporting an error during build preparation as such

---
 librepomgr/buildactions/preparebuild.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/librepomgr/buildactions/preparebuild.cpp b/librepomgr/buildactions/preparebuild.cpp
index 101684b..79c4a0c 100644
--- a/librepomgr/buildactions/preparebuild.cpp
+++ b/librepomgr/buildactions/preparebuild.cpp
@@ -921,9 +921,10 @@ void PrepareBuild::computeDependencies(WebClient::AurSnapshotQuerySession::Conta
     }
 
     auto resultData = makeResultData(std::move(error));
+    auto wasSuccess = resultData.error.empty() && resultData.cyclicLeftovers.empty();
     auto buildActionWriteLock = m_setup.building.lockToWrite();
     m_buildAction->resultData = std::move(resultData);
-    if (resultData.error.empty() && resultData.cyclicLeftovers.empty()) {
+    if (wasSuccess) {
         reportSuccess();
     } else {
         reportError();