Improve some JavaScript issues reported by eslint

srv/static/js/ajaxhelper.js

@@ -125,4 +125,4 @@ function checkForAjaxError(xhr, action)
     }
     showAjaxError(xhr, action);
     return true;
-}
+}

srv/static/js/buildactionspage.js

@@ -498,7 +498,7 @@ function renderBuildActionDetailsTable(buildActionDetails)
             },
             resultData: function(value, row) {
                 switch(value.index) {
-                case 3: // update info
+                case 3: { // update info
                     const formElement = document.createElement('form');
                     formElement.className = 'update-info-form';
                     formElement.appendChild(renderTableFromJsonObject({
@@ -534,6 +534,7 @@ function renderBuildActionDetailsTable(buildActionDetails)
                     };
                     formElement.appendChild(addSelectedInput);
                     return formElement;
+                }
                 case 4: // build preparation info
                     return renderTableFromJsonObject({
                         data: value.data,
@@ -547,7 +548,7 @@ function renderBuildActionDetailsTable(buildActionDetails)
                             },
                         },
                     });
-                case 7: // reporitory problems
+                case 7: { // reporitory problems
                     const container = document.createElement('div');
                     container.className = 'repo-problems';
                     for (const [database, problems] of Object.entries(value.data)) {
@@ -578,6 +579,7 @@ function renderBuildActionDetailsTable(buildActionDetails)
                         container.appendChild(table);
                     }
                     return container;
+                }
                 default:
                     return renderStandardTableCell(value.data);
                 }
@@ -821,7 +823,6 @@ function renderOrphanPackage(value, obj, level, row)
             package.version,
             row.sourceDbs,
         );
-        return document.createTextNode();
     }, function(package1, package2) {
         return package1.name.localeCompare(package2.name);
     });
@@ -901,4 +902,4 @@ function initBuildActionDetails(sectionElement, sectionData, newHashParts)
         queryBuildActionDetails(newBuildActionIds);
     }
     return true;
-}
+}

srv/static/js/customrendering.js

@@ -53,4 +53,4 @@ function renderIconLink(value, row, handler, tooltip, href, middleClickHref)
     const link = renderLink(renderIcon(value), row, handler, tooltip, href, middleClickHref);
     link.className = 'icon-link';
     return link;
-}
+}

srv/static/js/genericrendering.js

@@ -217,7 +217,7 @@ function renderTextPossiblyElidingTheEnd(value)
     element.appendChild(elipses);
     element.onclick = function () {
         element.removeChild(element.lastChild);
-        (expaned = !expaned) ? element.appendChild(remainingText) : element.appendChild(elipses);
+        ((expaned = !expaned)) ? element.appendChild(remainingText) : element.appendChild(elipses);
     };
     return element;
 }
@@ -629,4 +629,4 @@ function renderObjectWithHeadings(object, row, level)
         elements.push(heading, renderStandardTableCell(value, object, level));
     }
     return elements;
-}
+}

srv/static/js/globalstatuspage.js

@@ -186,4 +186,4 @@ window.functionsPostponedUntilGlobalInfo = [];
 window.hasGlobalStatus = false;
 window.buildActionStates = {};
 window.buildActionResults = {};
-window.buildActionTypes = {};
+window.buildActionTypes = {};

srv/static/js/log.js

@@ -18,4 +18,4 @@ function initLog()
         addSearchToTerminal(terminal, mainElement);
         terminal.open(mainElement);
     });
-}
+}

srv/static/js/packagedetailspage.js

@@ -114,4 +114,4 @@ function renderPackage(package, withoutBasics)
     });
     table.className = 'package-details-table';
     return table;
-}
+}

srv/static/js/packagesearchpage.js

@@ -34,4 +34,4 @@ function showPackageSearchResults(ajaxRequest)
         },
     });
     packageSearchResults.appendChild(table);
-}
+}

srv/static/js/terminal.js

@@ -75,4 +75,4 @@ function streamRouteIntoTerminal(method, path, terminal)
     ajaxRequest.open(method, apiPrefix + path, true);
     ajaxRequest.send();
     return ajaxRequest;
-}
+}

srv/static/js/utils.js

@@ -75,7 +75,7 @@ function alterFormSelection(form, command)
                 break;
             }
         });
-    };
+    }
 }
 
 function getProperty(object, property, fallback)
@@ -115,4 +115,4 @@ function getSelectedRowProperties(data, propertyName)
         }
     });
     return propertyValues;
-}
+}