Add note in cleanup action stating how many build actions have been deleted

This commit is contained in:
Martchus 2023-04-08 18:50:39 +02:00
parent 5af8de2468
commit 86581ec002
2 changed files with 4 additions and 2 deletions

View File

@ -520,6 +520,7 @@ void BuildServiceCleanup::run()
return --count <= stopAt;
},
&count);
m_messages.notes.emplace_back(argsToString("deleted ", count, " build actions"));
auto lock = lockToWrite();
m_dbCleanupConcluded = true;
conclude(std::move(lock));

View File

@ -950,7 +950,8 @@ void BuildActionsTests::testBuildServiceCleanup()
CPPUNIT_ASSERT_EQUAL_MESSAGE("failure", BuildActionResult::Failure, m_buildAction->result);
const auto &messages = std::get<BuildActionMessages>(m_buildAction->resultData);
CPPUNIT_ASSERT_EQUAL_MESSAGE("one error", 1_st, messages.errors.size());
TESTUTILS_ASSERT_LIKE("expected error", "unable to locate package cache directories:.*No such file or directory.*", messages.errors.front());
CPPUNIT_ASSERT_EQUAL_MESSAGE("one note", 1_st, messages.notes.size());
CPPUNIT_ASSERT_EQUAL_MESSAGE("no warnings", std::vector<std::string>(), messages.warnings);
CPPUNIT_ASSERT_EQUAL_MESSAGE("no notes", std::vector<std::string>(), messages.notes);
TESTUTILS_ASSERT_LIKE("expected error", "unable to locate package cache directories:.*No such file or directory.*", messages.errors.front());
TESTUTILS_ASSERT_LIKE("expected note", "deleted 1 build actions", messages.notes.front());
}