From 901092ba09d6c2bb1a6ec1405971c88ec5bf6175 Mon Sep 17 00:00:00 2001 From: Martchus Date: Mon, 5 Apr 2021 20:29:03 +0200 Subject: [PATCH] Fix condition for check whether reloading build action details is required --- srv/static/js/buildactionspage.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/srv/static/js/buildactionspage.js b/srv/static/js/buildactionspage.js index f1ad69a..9b39906 100644 --- a/srv/static/js/buildactionspage.js +++ b/srv/static/js/buildactionspage.js @@ -885,14 +885,12 @@ function initBuildActionDetails(sectionElement, sectionData, newHashParts) const hasCurrentlyBuildActions = Array.isArray(currentBuildActionIds) && currentBuildActionIds.length !== 0; if (!newHashParts.length) { if (hasCurrentlyBuildActions) { - window.preventHandlingHashChange = true; - window.location.hash = '#build-action-details-section?' + encodeURIComponent(currentBuildActionIds.join(',')); - window.preventHandlingHashChange = false; + updateHashPreventingChangeHandler('#build-action-details-section?' + encodeURIComponent(currentBuildActionIds.join(','))); } return true; } const newBuildActionIds = newHashParts[0].split(','); - if (!hasCurrentlyBuildActions || newBuildActionIds.some(id => !currentBuildActionIds.find(currentId => id == currentId))) { // possible type conversion wanted + if (!hasCurrentlyBuildActions || newBuildActionIds.some(id => currentBuildActionIds.find(currentId => id == currentId) === undefined)) { // possible type conversion wanted queryBuildActionDetails(newBuildActionIds); } return true;