Martchus
/
arch-repo-manager
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix memory leak in archiving utilities

This commit is contained in:
Martchus 2024-03-07 00:29:43 +01:00
parent 5d9d6b0bba
commit a43fec4868
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libpkg/parser/utils.cpp
View File

@ -74,7 +74,7 @@ void walkThroughArchiveInternal(struct archive *ar, const string &archiveName, c
}
if (directoryHandler(std::string_view(filePath, dirEnd))) {
return;
goto free;
}
continue;
}
@ -101,7 +101,7 @@ void walkThroughArchiveInternal(struct archive *ar, const string &archiveName, c
if (entryType == AE_IFLNK) {
if (fileHandler(std::string_view(filePath, static_cast<string::size_type>(dirEnd - filePath)),
ArchiveFile(fileName, std::string(archive_entry_symlink_utf8(entry)), ArchiveFileType::Link, creationTime, modificationTime))) {
return;
goto free;
}
continue;
}
@ -128,11 +128,12 @@ void walkThroughArchiveInternal(struct archive *ar, const string &archiveName, c
// move it to results
if (fileHandler(std::string_view(filePath, static_cast<string::size_type>(dirEnd - filePath)),
ArchiveFile(fileName, std::move(fileContent), ArchiveFileType::Regular, creationTime, modificationTime))) {
return;
goto free;
}
}
// free resources used by libarchive
free:
archive_entry_free(entry);
int returnCode = archive_read_free(ar);
if (returnCode != ARCHIVE_OK) {