From 4e2539548da43f8291be4810bfc01cc6161b86eb Mon Sep 17 00:00:00 2001 From: Martchus Date: Wed, 12 Jun 2019 20:33:43 +0200 Subject: [PATCH] Remove FALLTHROUGH macro Since this is requiring C++17 anyways there's no need for it anymore. --- application/argumentparser.cpp | 2 +- application/global.h | 11 ----------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/application/argumentparser.cpp b/application/argumentparser.cpp index ff6b3d5..28932f9 100644 --- a/application/argumentparser.cpp +++ b/application/argumentparser.cpp @@ -374,7 +374,7 @@ bool ArgumentReader::read(ArgumentVector &args) switch (parser.m_unknownArgBehavior) { case UnknownArgumentBehavior::Warn: cerr << Phrases::Warning << "The specified argument \"" << *argv << "\" is unknown and will be ignored." << Phrases::EndFlush; - FALLTHROUGH; + [[fallthrough]]; case UnknownArgumentBehavior::Ignore: // ignore unknown denotation ++index; diff --git a/application/global.h b/application/global.h index 19749bd..20dc32b 100644 --- a/application/global.h +++ b/application/global.h @@ -102,16 +102,5 @@ #define IF_DEBUG_BUILD(x) #endif -/*! - * \def FALLTHROUGH - * \brief Prevents clang from warning about missing break in switch-case. - * \remarks Does nothing if another compiler is used. - */ - -#ifdef __clang__ -#define FALLTHROUGH [[clang::fallthrough]] -#else -#define FALLTHROUGH -#endif #endif // APPLICATION_UTILITIES_GLOBAL_H