From a9cb91bee2d0fc707b992e35c35808762c7f1a69 Mon Sep 17 00:00:00 2001 From: Martchus Date: Fri, 10 Jan 2020 18:05:55 +0100 Subject: [PATCH] Set default visibility explicitely to hidden Hidden default visibility is already expected to be handled by users of the library because it is the default under Windows. --- cmake/modules/AppTarget.cmake | 2 ++ cmake/modules/LibraryTarget.cmake | 2 ++ cmake/modules/TestTarget.cmake | 9 +++++++-- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/cmake/modules/AppTarget.cmake b/cmake/modules/AppTarget.cmake index 7070183..ac2fd1f 100644 --- a/cmake/modules/AppTarget.cmake +++ b/cmake/modules/AppTarget.cmake @@ -62,6 +62,8 @@ target_compile_options( set_target_properties( ${META_TARGET_NAME} PROPERTIES CXX_STANDARD "${META_CXX_STANDARD}" + C_VISIBILITY_PRESET hidden + CXX_VISIBILITY_PRESET hidden LINK_SEARCH_START_STATIC ${STATIC_LINKAGE} LINK_SEARCH_END_STATIC ${STATIC_LINKAGE} AUTOGEN_TARGET_DEPENDS "${AUTOGEN_DEPS}") diff --git a/cmake/modules/LibraryTarget.cmake b/cmake/modules/LibraryTarget.cmake index a0bd8c8..9dae12b 100644 --- a/cmake/modules/LibraryTarget.cmake +++ b/cmake/modules/LibraryTarget.cmake @@ -149,6 +149,8 @@ else () PROPERTIES VERSION "${META_VERSION_MAJOR}.${META_VERSION_MINOR}.${META_VERSION_PATCH}" SOVERSION "${META_SOVERSION}" CXX_STANDARD "${META_CXX_STANDARD}" + C_VISIBILITY_PRESET hidden + CXX_VISIBILITY_PRESET hidden LINK_SEARCH_START_STATIC ${STATIC_LINKAGE} LINK_SEARCH_END_STATIC ${STATIC_LINKAGE} AUTOGEN_TARGET_DEPENDS "${AUTOGEN_DEPS}") diff --git a/cmake/modules/TestTarget.cmake b/cmake/modules/TestTarget.cmake index 935f7d5..56c8e81 100644 --- a/cmake/modules/TestTarget.cmake +++ b/cmake/modules/TestTarget.cmake @@ -132,6 +132,8 @@ if (META_PROJECT_IS_APPLICATION) set_target_properties( ${META_TARGET_NAME}_testlib PROPERTIES CXX_STANDARD "${META_CXX_STANDARD}" + C_VISIBILITY_PRESET hidden + CXX_VISIBILITY_PRESET hidden LINK_SEARCH_START_STATIC ${STATIC_LINKAGE} LINK_SEARCH_END_STATIC ${STATIC_LINKAGE} AUTOGEN_TARGET_DEPENDS "${AUTOGEN_DEPS}") @@ -168,8 +170,11 @@ target_compile_options( PRIVATE "${META_PRIVATE_COMPILE_OPTIONS}") set_target_properties( ${META_TARGET_NAME}_tests - PROPERTIES CXX_STANDARD "${META_CXX_STANDARD}" LINK_SEARCH_START_STATIC ${STATIC_LINKAGE} LINK_SEARCH_END_STATIC - ${STATIC_LINKAGE}) + PROPERTIES CXX_STANDARD "${META_CXX_STANDARD}" + C_VISIBILITY_PRESET hidden + CXX_VISIBILITY_PRESET hidden + LINK_SEARCH_START_STATIC ${STATIC_LINKAGE} + LINK_SEARCH_END_STATIC ${STATIC_LINKAGE}) # make the test recognized by ctest unset(RUN_TESTS_APPLICATION_ARG)