From 68f0bff172f77390dfad798f12e4a56e0c1f35d4 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Fri, 8 Nov 2019 09:40:09 -0500 Subject: [PATCH] commitpkg: clearly delineate the commit message template and the rationale In commit 75d23eec942e7160108ee194894b6b83ed3045d5 we moved to include commitpkg arguments as the first line of the svn commit message, but we simply dumped the result after the version number without separating the two, increasing the cognitive burden of parsing the rationale. Since the whole point of the change was to make it easier to see what happened when using git log --oneline (reducing the cognitive burden of parsing 'pretty' output with author/date info), it makes sense to also delineate the reason correctly. Signed-off-by: Eli Schwartz --- commitpkg.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commitpkg.in b/commitpkg.in index 806d353..eb0fc55 100644 --- a/commitpkg.in +++ b/commitpkg.in @@ -112,7 +112,7 @@ if [[ -n $(svn status -q) ]]; then msgtemplate="upgpkg: $pkgbase $(get_full_version)" if [[ -n $1 ]]; then stat_busy 'Committing changes to trunk' - svn commit -q -m "${msgtemplate} ${1}" || die + svn commit -q -m "${msgtemplate}: ${1}" || die stat_done else msgfile="$(mktemp)"