If the find command cannot descend into a directory in order to search
for a PKGBUILD, it is likely a "$pkgdir" which makepkg sets as
unreadable. As far as finddeps is concerned, this error message is not
needed.
Also convert to using null-delimited paths on general principle to
prevent read from splitting on odd paths.
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Levente Polyak <anthraxx@archlinux.org>
- Use `read -r` instead of other forms of read or looping
- Use arrays instead of strings with whitespaces.
- In one instance, use ${var%%.*} instead of $(echo $var|cut -f. -d1)
In cases where there is no license specified, the file is tagged as
"License: Unspecified". Obviously, that is not ideal, but it
highlights the fact, and I hope that it encourages whoever has the
authority to specify the license to do so.
On that note, to anyone who may have the authority to specify the
license of files in devtools: the current licence of many files is
GPLv2 with no option for later versions; I impore you to re-license
them to have the "or any later version" option.
The usage messages now begins with a "Usage:", i.e. capitalized and with a colon. Fixes FS#26956.
Signed-off-by: Eric Bélanger <snowmaniscool@gmail.com>
Signed-off-by: Pierre Schmitz <pierre@archlinux.de>
The optdepends array should be unset before sourcing the PKGBUILD to avoid
dangling optional depends.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Using parameter substitution might result in unpredictable behaviour
when directories contain whitespaces here. The read shell builtin is the
proper way to read single lines.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Source the PKGBUILD using the correct path (relative to our base
directory) instead of using cd(1) to switch to the ABS base directory
first and to the package directory afterwards.
This is very useful when trying to track errors, also:
$ ~/src/devtools/finddeps libdaq
./community/snort (depends)
PKGBUILD: line 17: ruby: command not found
PKGBUILD: line 19: [: =: unary operator expected
Versus:
$ ~/src/devtools/finddeps libdaq
./community/snort (depends)
./community/ruby-pkgconfig/PKGBUILD: line 17: ruby: command not found
./community/lmms/PKGBUILD: line 19: [: =: unary operator expected
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
This build system overhaul allows for adding (define-style) macros to
our scripts. All source files are now suffixed with ".in" to clarify
that they might contain unprocessed defines. The Makefile provides a new
rule to preprocess source files and generate proper output scripts.
Also, add a "@pkgdatadir@" define (as used in GNU Autotools) and use it
instead of hardcoded paths to "/usr/share/devtools" everywhere. We
missed this when adding PREFIX support to the build system in commit
35fc83ce7d.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Eli Schwartz
Luke Shumaker
Eric Bélanger
Pierre Schmitz
Lukas Fleischer