Fork of Arch Linux devtools from https://git.archlinux.org/devtools.git
Go to file
Luke Shumaker 2fd5931a8c
makechrootpkg: Have functions be more function-y.
Rather than them simply being named blocks of code with braces around
them.

That is: have them take things via arguments rather than global
variables.

Specific notes:

 - create_chroot->sync_chroot:

   I pulled out locking the destination chroot; getting that lock is
   now the caller's responsibility.  It still handles locking the
   source chroot though.

   I pulled the `if [[ ! -d $copydir ]] || $clean_first;` check out; it is
   now the caller's responsibility to use that check when deciding if to
   call sync_chroot.

   However, when pulling that check out, I left it as `if true;`, to
   keep an indentation level.  This patch has had to be rebased/merged
   many times, and changing the indentation is a sure way to make that
   go less smoothly; I'm not going to re-indent this block until I see
   the check removed in the git.archlinux.org/devtools.git repository.

 - install_packages:

    1. Receive the list of packages as arguments, rather than a global
       variable.
    2. Make the caller responsible for looking at PKGBUILD.  From the
       name and arguments, one would never expect it to look at PKGBUILD.
2017-04-05 22:17:51 +02:00
lib lib/common.sh: Make it safe to include multiple times. 2017-04-05 22:14:20 +02:00
.gitignore Update .gitignore 2013-05-25 22:17:30 +02:00
Makefile Version 20170320 2017-03-20 19:23:50 +01:00
arch-nspawn.in Avoid using string interpolation; use printf format strings instead. 2017-04-05 22:11:16 +02:00
archbuild.in Avoid using string interpolation; use printf format strings instead. 2017-04-05 22:11:16 +02:00
archco.in Avoid using string interpolation; use printf format strings instead. 2017-04-05 22:11:16 +02:00
archrelease.in Avoid using string interpolation; use printf format strings instead. 2017-04-05 22:11:16 +02:00
archrm.in Add a "License:" tag to all code files. 2017-04-05 22:10:03 +02:00
bash_completion.in Add a "License:" tag to all code files. 2017-04-05 22:10:03 +02:00
checkpkg.in Handle makepkg.conf more consistently 2017-04-05 22:17:51 +02:00
commitpkg.in Handle makepkg.conf more consistently 2017-04-05 22:17:51 +02:00
crossrepomove.in Avoid using string interpolation; use printf format strings instead. 2017-04-05 22:11:16 +02:00
find-libdeps.in Add a "License:" tag to all code files. 2017-04-05 22:10:03 +02:00
finddeps.in Add a "License:" tag to all code files. 2017-04-05 22:10:03 +02:00
lddd.in Avoid using string interpolation; use printf format strings instead. 2017-04-05 22:11:16 +02:00
makechrootpkg.in makechrootpkg: Have functions be more function-y. 2017-04-05 22:17:51 +02:00
makepkg-i686.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
makepkg-x86_64.conf Set target vendor to pc for usge with gcc 6 2016-05-07 10:53:48 +02:00
mkarchroot.in Avoid using string interpolation; use printf format strings instead. 2017-04-05 22:11:16 +02:00
pacman-extra.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-gnome-unstable.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-kde-unstable.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-multilib-staging.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-multilib-testing.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-multilib.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-staging.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-testing.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
rebuildpkgs.in Handle makepkg.conf more consistently 2017-04-05 22:17:51 +02:00
zsh_completion.in Add a "License:" tag to all code files. 2017-04-05 22:10:03 +02:00