Fork of Arch Linux devtools from https://git.archlinux.org/devtools.git
Go to file
Eli Schwartz 48b2f8dcc4 makechrootpkg: Fix anti-pattern when checking for enabled features
Don't use error-prone logic e.g.
foo=true; if $foo ...

This completely fails to act as expected when the variable is unset
because of unrelated bugs.

While this merely causes the default behavior to be "false" rather than
"true" in such cases, it is better to fail to enable explicitly
requested behavior (which will be noticed by the user) than to simply
upgrade to this behavior for free (which may not seem to have any
obvious cause).

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
2018-01-21 14:16:10 +01:00
lib Support reproducible builds 2017-11-22 16:35:25 +01:00
.gitignore Update .gitignore 2013-05-25 22:17:30 +02:00
Makefile Version 20171108 2017-11-08 14:23:26 +01:00
PKGBUILD.proto Add `# shellcheck` directives to quiet shellcheck, add PKGBUILD.proto 2017-07-05 18:21:56 +02:00
arch-nspawn.in Revert "arch-nspawn: Hack to give the inner process a controlling terminal" 2017-09-13 00:25:06 +02:00
archbuild.in Support reproducible builds 2017-11-22 16:35:25 +01:00
archco.in Avoid using string interpolation; use printf format strings instead. 2017-04-05 22:11:16 +02:00
archrelease.in archrelease: Whitespace adjustment 2017-07-05 18:35:16 +02:00
archrm.in Quote strings that shellcheck warns about. 2017-07-05 18:21:56 +02:00
bash_completion.in Quote strings that shellcheck warns about. 2017-07-05 18:21:56 +02:00
checkpkg.in Add `# shellcheck` directives to quiet shellcheck, add PKGBUILD.proto 2017-07-05 18:21:56 +02:00
commitpkg.in Remove i686 support 2017-11-08 14:22:56 +01:00
crossrepomove.in Add `# shellcheck` directives to quiet shellcheck, add PKGBUILD.proto 2017-07-05 18:21:56 +02:00
find-libdeps.in Make slightly more involved changes to make shellcheck happy. 2017-07-05 18:21:56 +02:00
finddeps.in Add `# shellcheck` directives to quiet shellcheck, add PKGBUILD.proto 2017-07-05 18:21:56 +02:00
lddd.in Make slightly more involved changes to make shellcheck happy. 2017-07-05 18:21:56 +02:00
makechrootpkg.in makechrootpkg: Fix anti-pattern when checking for enabled features 2018-01-21 14:16:10 +01:00
makepkg-x86_64.conf Add `# shellcheck` directives to quiet shellcheck, add PKGBUILD.proto 2017-07-05 18:21:56 +02:00
mkarchroot.in Quote strings that shellcheck warns about. 2017-07-05 18:21:56 +02:00
pacman-extra.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-gnome-unstable.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-kde-unstable.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-multilib-staging.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-multilib-testing.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-multilib.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-staging.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
pacman-testing.conf Update bundled pacman and makepkg configuration 2016-02-07 10:12:56 +01:00
rebuildpkgs.in Add `# shellcheck` directives to quiet shellcheck, add PKGBUILD.proto 2017-07-05 18:21:56 +02:00
zsh_completion.in Remove i686 support 2017-11-08 14:22:56 +01:00