Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Prevent user from using --stop with ambiguous args 

When both --scan and device name is passed to --stop action,
then is executed only for given device. Scan is ignored.

Block the operation when both --scan and device name are passed.

Signed-off-by: Norbert Szulc <norbert.szulc@intel.com>
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
This commit is contained in:
Norbert Szulc 2021-05-05 13:01:02 +02:00 committed by Jes Sorensen
parent 83b3de7795
commit 0530e2e0d8
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mdadm.c
View File

@ -2041,6 +2041,11 @@ static int misc_list(struct mddev_dev *devlist,
rv |= Manage_run(dv->devname, mdfd, c);
break;
case 'S':
if (c->scan) {
pr_err("--stop not meaningful with both a --scan assembly and a device name.\n");
rv |= 1;
break;
}
rv |= Manage_stop(dv->devname, mdfd, c->verbose, 0);
break;
case 'o':