Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Specify nodes number when updating cluster nodes 

Now it allows updating cluster nodes without specify --nodes. It can write superblock
with zero nodes. It can break the current cluster. Add this check to avoid this problem.

v2: It needs check c.update first to avoid NULL pointer reference
v3: Wol points the typo error

Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
This commit is contained in:
Xiao Ni 2020-07-27 09:14:20 +08:00 committed by Jes Sorensen
parent 77b72fa828
commit 138a9e9bbe
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mdadm.c
View File

@ -1433,6 +1433,11 @@ int main(int argc, char *argv[])
}
}
if (c.update && strcmp(c.update, "nodes") == 0 && c.nodes == 0) {
pr_err("Please specify nodes number with --nodes\n");
exit(1);
}
if (c.backup_file && data_offset != INVALID_SECTORS) {
pr_err("--backup-file and --data-offset are incompatible\n");
exit(2);