Specify nodes number when updating cluster nodes
Now it allows updating cluster nodes without specify --nodes. It can write superblock with zero nodes. It can break the current cluster. Add this check to avoid this problem. v2: It needs check c.update first to avoid NULL pointer reference v3: Wol points the typo error Signed-off-by: Xiao Ni <xni@redhat.com> Signed-off-by: Jes Sorensen <jsorensen@fb.com>
This commit is contained in:
parent
77b72fa828
commit
138a9e9bbe
5
mdadm.c
5
mdadm.c
|
@ -1433,6 +1433,11 @@ int main(int argc, char *argv[])
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (c.update && strcmp(c.update, "nodes") == 0 && c.nodes == 0) {
|
||||||
|
pr_err("Please specify nodes number with --nodes\n");
|
||||||
|
exit(1);
|
||||||
|
}
|
||||||
|
|
||||||
if (c.backup_file && data_offset != INVALID_SECTORS) {
|
if (c.backup_file && data_offset != INVALID_SECTORS) {
|
||||||
pr_err("--backup-file and --data-offset are incompatible\n");
|
pr_err("--backup-file and --data-offset are incompatible\n");
|
||||||
exit(2);
|
exit(2);
|
||||||
|
|
Loading…
Reference in New Issue