Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mdadm/grow: adding a test to ensure resize was required 

To fix the commit: 4b74a905a6
(mdadm/grow: Component size must be larger than chunk size)

array.level > 1 : against the raids which chunk_size is meaningful.
s->size > 0 : ensure that changing component size has required.
array.chunk_size / 1024 > s->size : ensure component size should
be always >= current chunk_size when requires resize, otherwise,
mddev->pers->resize would be set mddev->dev_sectors as '0'.

Reported-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
Suggested-by: NeilBrown <neilb@suse.com>
Signed-off-by: Zhilong Liu <zlliu@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
This commit is contained in:
Zhilong Liu 2017-10-11 16:53:12 +08:00 committed by Jes Sorensen
parent f93b797b71
commit 1b21c449e6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Grow.c
View File

@ -1809,8 +1809,8 @@ int Grow_reshape(char *devname, int fd,
return 1;
}
if (array.level > 1 &&
(array.chunk_size / 1024) > (int)s->size) {
if (array.level > 1 && s->size > 0 &&
(array.chunk_size / 1024) > (int)s->size) {
pr_err("component size must be larger than chunk size.\n");
return 1;
}