From 2b60d2890faa8b3dc361a163ea745380c1305c96 Mon Sep 17 00:00:00 2001 From: "mwilck@arcor.de" Date: Fri, 25 Oct 2013 12:07:36 +0200 Subject: [PATCH] monitor: don't call pselect() on deleted sysfs files It makes no sense to listen for events on files that have been deleted. This happens when arrays are stopped and the kernel removes the associated sysfs structures. Calling pselect() on the deleted attributes may cause a storm of wake events. Signed-off-by: Martin Wilck Signed-off-by: NeilBrown --- monitor.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/monitor.c b/monitor.c index e034a6a..3cb4214 100644 --- a/monitor.c +++ b/monitor.c @@ -38,8 +38,17 @@ static int write_attr(char *attr, int fd) static void add_fd(fd_set *fds, int *maxfd, int fd) { + struct stat st; if (fd < 0) return; + if (fstat(fd, &st) == -1) { + dprintf("%s: Invalid fd %d\n", __func__, fd); + return; + } + if (st.st_nlink == 0) { + dprintf("%s: fd %d was deleted\n", __func__, fd); + return; + } if (fd > *maxfd) *maxfd = fd; FD_SET(fd, fds);