Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

imsm: FIX: mdmon crash during 2 raid0 arrays expansion 

When expansion is run on 2 raid0 arrays in container no update
is sent to mdmon because mdmon is off (mdadm performs update)
Memory size for first reshaped array is allocated to satisfy memory
requirements for expanded maps.
Memory for second device is allocated using old disks number, as in
metadata there is no information about this array reshape.
When mdmon initiates second array reshape it overwrites internal
structures and crashes). There is no place to keep expanded maps.
To avoid this situation during loading metadata, allocated memory
should be performed using the maximum used disks number in particular
container.

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
Adam Kwolek 2011-01-31 15:25:16 +01:00 committed by NeilBrown
parent 820eb8dba7
commit 401d313b7f
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
super-intel.c
View File

@ -2471,6 +2471,7 @@ static int parse_raid_devices(struct intel_super *super)
int i;
struct imsm_dev *dev_new;
size_t len, len_migr;
size_t max_len = 0;
size_t space_needed = 0;
struct imsm_super *mpb = super->anchor;
@ -2486,7 +2487,11 @@ static int parse_raid_devices(struct intel_super *super)
dv = malloc(sizeof(*dv));
if (!dv)
return 1;
dev_new = malloc(len_migr);
if (max_len < len_migr)
max_len = len_migr;
if (max_len > len_migr)
space_needed += max_len - len_migr;
dev_new = malloc(max_len);
if (!dev_new) {
free(dv);
return 1;