Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mdcheck: use ${} to pass variable to mdcheck 

$MDADM_CHECK_DURATION allows the value to be split on spaces.
${MDADM_CHECK_DURATION} avoids such splitting.

Making this change removes the need for double quoting when setting
the default Environment, and means that double quoting isn't needed
in the EnvironmentFile.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
This commit is contained in:
NeilBrown 2019-10-30 10:32:41 +11:00 committed by Jes Sorensen
parent 6636788aaf
commit 4ca799c581
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
systemd/mdcheck_continue.service
View File

@ -11,8 +11,7 @@ ConditionPathExistsGlob = /var/lib/mdcheck/MD_UUID_*
[Service]
Type=oneshot
Environment= MDADM_CHECK_DURATION='"6 hours"'
Environment= MDADM_CHECK_DURATION="6 hours"
EnvironmentFile=-/run/sysconfig/mdadm
ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --continue --duration $MDADM_CHECK_DURATION
ExecStart=/usr/share/mdadm/mdcheck --continue --duration ${MDADM_CHECK_DURATION}

4
systemd/mdcheck_start.service
View File

@ -11,7 +11,7 @@ Wants=mdcheck_continue.timer
[Service]
Type=oneshot
Environment= MDADM_CHECK_DURATION='"6 hours"'
Environment= MDADM_CHECK_DURATION="6 hours"
EnvironmentFile=-/run/sysconfig/mdadm
ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --duration $MDADM_CHECK_DURATION
ExecStart=/usr/share/mdadm/mdcheck --duration ${MDADM_CHECK_DURATION}