Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

IncRemove: Set "auto-read" only after successful excl open. 

"mdadm -If" - triggered from udev rules when disk is removed from OS -
tries to set array in auto-read-only mode. This can interrupt rebuild
process which is started automatically, e.g. if array is mounted and
spare disk is available (I/O error is detected faster than removing
failed disk by mdadm).
This patch prevents "mdadm -If" from setting array into "auto-read-only",
by requiring exclusive open to succeed.

Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
Pawel Baldysiak 2015-02-27 15:47:54 +01:00 committed by NeilBrown
parent f666bcc652
commit 4d149ab517
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Incremental.c
View File

@ -1712,12 +1712,16 @@ int IncrementalRemove(char *devname, char *id_path, int verbose)
return 1;
}
sysfs_init(&mdi, -1, ent->devnm);
if (sysfs_get_str(&mdi, NULL, "array_state",
buf, sizeof(buf)) > 0) {
if (strncmp(buf, "active", 6) == 0 ||
strncmp(buf, "clean", 5) == 0)
sysfs_set_str(&mdi, NULL,
"array_state", "read-auto");
mdfd = open_dev_excl(ent->devnm);
if (mdfd > 0) {
close(mdfd);
if (sysfs_get_str(&mdi, NULL, "array_state",
buf, sizeof(buf)) > 0) {
if (strncmp(buf, "active", 6) == 0 ||
strncmp(buf, "clean", 5) == 0)
sysfs_set_str(&mdi, NULL,
"array_state", "read-auto");
}
}
mdfd = open_dev(ent->devnm);
if (mdfd < 0) {