Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

DDF: compare_super_ddf: fix sequence number check 

The sequence number check in compare_super_ddf was broken,
anchor sequence number is always -1.

With this patch, mdadm will refuse to add a disk with non-matching
sequence number.

This fixes Francis Moreau's problem reported with subject
"mdadm 3.3 fails to kick out non fresh disk".

FIXME: More work is needed here. Currently mdadm won't even add the
disk to the container, that's wrong. It should be added as a spare.

Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
mwilck@arcor.de 2013-09-14 22:47:12 +02:00 committed by NeilBrown
parent aa0faa10b2
commit 7039479987
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
super-ddf.c
View File

@ -3892,10 +3892,10 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
if (memcmp(first->anchor.guid, second->anchor.guid, DDF_GUID_LEN) != 0)
return 2;
if (!be32_eq(first->anchor.seq, second->anchor.seq)) {
dprintf("%s: sequence number mismatch %u/%u\n", __func__,
be32_to_cpu(first->anchor.seq),
be32_to_cpu(second->anchor.seq));
if (!be32_eq(first->active->seq, second->active->seq)) {
dprintf("%s: sequence number mismatch %u<->%u\n", __func__,
be32_to_cpu(first->active->seq),
be32_to_cpu(second->active->seq));
return 3;
}
if (first->max_part != second->max_part ||