Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

imsm: Fix: klocwork: targets variable can be used uninitialized 

When target_offsets allocation fails execution goes to abort label,
where elements from targets table are closed.

Initialize targets table after allocation.

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
Adam Kwolek 2011-06-14 12:48:53 +10:00 committed by NeilBrown
parent e1c1d4f442
commit 7e45b5504c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
super-intel.c
View File

@ -7716,13 +7716,15 @@ int save_backup_imsm(struct supertype *st,
if (!targets)
goto abort;
for (i = 0; i < new_disks; i++)
targets[i] = -1;
target_offsets = malloc(new_disks * sizeof(unsigned long long));
if (!target_offsets)
goto abort;
start = info->reshape_progress * 512;
for (i = 0; i < new_disks; i++) {
targets[i] = -1;
target_offsets[i] = (unsigned long long)
__le32_to_cpu(super->migr_rec->ckpt_area_pba) * 512;
/* move back copy area adderss, it will be moved forward