From 8aedc4eaf6efbe9fda78821e38e395fb322e72d1 Mon Sep 17 00:00:00 2001 From: Przemyslaw Czarnowski Date: Tue, 6 Dec 2011 11:41:27 +1100 Subject: [PATCH] imsm: fix: does not allow to use invalid chunk size Only least significant bit of chunk size provided by user has been used in test with OROM capabilities. This way user could pass value which is not a power of 2. Signed-off-by: Przemyslaw Czarnowski Signed-off-by: NeilBrown --- platform-intel.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/platform-intel.h b/platform-intel.h index 6c094d7..99450ba 100644 --- a/platform-intel.h +++ b/platform-intel.h @@ -124,11 +124,13 @@ static inline int imsm_orom_has_raid5(const struct imsm_orom *orom) static inline int imsm_orom_has_chunk(const struct imsm_orom *orom, int chunk) { int fs = ffs(chunk); + int orom_chunk_bit; if (!fs) return 0; fs--; /* bit num to bit index */ - return !!(orom->sss & (1 << (fs - 1))); + orom_chunk_bit = (orom->sss & (1 << (fs - 1))); + return orom_chunk_bit && 1 << orom_chunk_bit == chunk; }