From 8c80d3055bcaab4c449abb7b666aad69d054347a Mon Sep 17 00:00:00 2001 From: Coly Li Date: Thu, 2 Sep 2021 15:32:20 +0800 Subject: [PATCH] Monitor: print message before quit for no array to monitor If there is no array device to monitor, Monitor() will stop monitoring at line 261 from the following code block, 257 if (!new_found) { 258 if (oneshot) 259 break; 260 else if (!anyredundant) { 261 break; 262 } This change was introduced by commit 007087d0898a ("Monitor: stop notifing about containers"). Before this commit, Monitor() will continue and won't quit even there is no array to monitor. It is fine to quit without any array device to monitor, but users may wonder whether there is something wrong with mdadm program or their configuration to make mdadm quit monitoring. This patch adds a simple error message to indicate Monitor() quits for array device to monitor, which makes users have hint to understand why mdadm stops monitoring. Reported-by: George Gkioulis Suggested-by: Mariusz Tkaczyk Signed-off-by: Coly Li Cc: Jes Sorensen Signed-off-by: Jes Sorensen --- Monitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Monitor.c b/Monitor.c index 8bd3b5a..30c031a 100644 --- a/Monitor.c +++ b/Monitor.c @@ -258,6 +258,7 @@ int Monitor(struct mddev_dev *devlist, if (oneshot) break; else if (!anyredundant) { + pr_err("No array with redundancy detected, stopping\n"); break; } else {