Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

imsm: Function imsm_set_disk() rework 

Rework is needed to map state transition part to allow easier code reading.
After rework it is easy to find out what can happen in what map state
transition.

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
Adam Kwolek 2011-12-07 13:57:59 +01:00 committed by NeilBrown
parent 809da78e60
commit 94002678b6
1 changed files with 68 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

102
super-intel.c
View File

@ -6446,49 +6446,83 @@ static void imsm_set_disk(struct active_array *a, int n, int state)
map_state = imsm_check_degraded(super, dev, failed, MAP_0);
/* check if recovery complete, newly degraded, or failed */
if (map_state == IMSM_T_STATE_NORMAL && is_rebuilding(dev)) {
end_migration(dev, super, map_state);
map = get_imsm_map(dev, 0);
map->failed_disk_num = ~0;
super->updates_pending++;
a->last_checkpoint = 0;
} else if (map_state == IMSM_T_STATE_DEGRADED &&
map->map_state != map_state &&
!dev->vol.migr_state) {
dprintf("imsm: mark degraded\n");
map->map_state = map_state;
super->updates_pending++;
a->last_checkpoint = 0;
} else if (map_state == IMSM_T_STATE_FAILED &&
map->map_state != map_state) {
dprintf("imsm: mark failed\n");
end_migration(dev, super, map_state);
super->updates_pending++;
a->last_checkpoint = 0;
} else if (is_gen_migration(dev)) {
dprintf("imsm: Detected General Migration in state: ");
switch (map_state) {
case IMSM_T_STATE_NORMAL:
dprintf("normal\n");
if (a->last_checkpoint >= a->info.component_size)
end_migration(dev, super, map_state);
dprintf("imsm: Detected transition to state ");
switch (map_state) {
case IMSM_T_STATE_NORMAL: /* transition to normal state */
dprintf("normal: ");
if (is_rebuilding(dev)) {
dprintf("while rebuilding");
end_migration(dev, super, map_state);
map = get_imsm_map(dev, 0);
map->failed_disk_num = ~0;
super->updates_pending++;
a->last_checkpoint = 0;
break;
case IMSM_T_STATE_DEGRADED:
dprintf("degraded\n");
}
if (is_gen_migration(dev)) {
dprintf("while general migration");
if (a->last_checkpoint >= a->info.component_size)
end_migration(dev, super, map_state);
else
manage_second_map(super, dev);
map->map_state = map_state;
map = get_imsm_map(dev, 0);
map->failed_disk_num = ~0;
super->updates_pending++;
break;
default:
dprintf("failed\n");
}
map->map_state = map_state;
super->updates_pending++;
break;
case IMSM_T_STATE_DEGRADED: /* transition to degraded state */
dprintf("degraded: ");
if ((map->map_state != map_state) &&
!dev->vol.migr_state) {
dprintf("mark degraded");
map->map_state = map_state;
super->updates_pending++;
a->last_checkpoint = 0;
break;
}
if (is_rebuilding(dev)) {
dprintf("while rebuilding.");
if (map->map_state != map_state) {
dprintf(" Map state change");
end_migration(dev, super, map_state);
super->updates_pending++;
}
break;
}
if (is_gen_migration(dev)) {
dprintf("while general migration");
if (a->last_checkpoint >= a->info.component_size)
end_migration(dev, super, map_state);
else {
map->map_state = map_state;
manage_second_map(super, dev);
}
super->updates_pending++;
break;
}
break;
case IMSM_T_STATE_FAILED: /* transition to failed state */
dprintf("failed: ");
if (is_gen_migration(dev)) {
dprintf("while general migration");
map->map_state = map_state;
super->updates_pending++;
break;
}
if (map->map_state != map_state) {
dprintf("mark failed");
end_migration(dev, super, map_state);
super->updates_pending++;
a->last_checkpoint = 0;
break;
}
break;
default:
dprintf("state %i\n", map_state);
}
dprintf("\n");
}
static int store_imsm_mpb(int fd, struct imsm_super *mpb)