Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

imsm: Block volume creation with empty name 

There is a possibility to create a RAID with empty name. Block it. Also
remove trailing and leading whitespaces from given name.

Signed-off-by: Roman Sobanski <roman.sobanski@intel.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
This commit is contained in:
Roman Sobanski 2018-08-10 14:20:35 +02:00 committed by Jes Sorensen
parent 29d7f182a5
commit 9bd99a90e1
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
super-intel.c
View File

@ -5285,10 +5285,22 @@ static int check_name(struct intel_super *super, char *name, int quiet)
{
struct imsm_super *mpb = super->anchor;
char *reason = NULL;
char *start = name;
size_t len = strlen(name);
int i;
if (strlen(name) > MAX_RAID_SERIAL_LEN)
if (len > 0) {
while (isspace(start[len - 1]))
start[--len] = 0;
while (*start && isspace(*start))
++start, --len;
memmove(name, start, len + 1);
}
if (len > MAX_RAID_SERIAL_LEN)
reason = "must be 16 characters or less";
else if (len == 0)
reason = "must be a non-empty string";
for (i = 0; i < mpb->num_raid_devs; i++) {
struct imsm_dev *dev = get_imsm_dev(super, i);