Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

FIX: Unfreeze array on success only 

Unfreeze array on success only.
rv is initialized by restart variable so we have 2 cases.
1. regular reshape start
	rv == restart == 0
   this means that real error (returned by reshape) can cause leaving container frozen
   If array is not touched by reshape it can be unfrozen
2. During reshape restart even untouched array under reshape is left unfrozen,
   If reshape is started do not unfreeze array on error also.

This allows user for array repair action
(mdmon will not change array state).

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
Adam Kwolek 2011-03-10 08:30:42 +01:00 committed by NeilBrown
parent ca6529edf6
commit bcc9e9edd0
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Grow.c
View File

@ -2205,6 +2205,7 @@ int reshape_container(char *container, char *devname,
int quiet, int restart)
{
struct mdinfo *cc = NULL;
int rv = restart;
/* component_size is not meaningful for a container,
* so pass '-1' meaning 'no change'
@ -2249,7 +2250,6 @@ int reshape_container(char *container, char *devname,
* will take over the reshape.
*/
struct mdinfo *content;
int rv;
int fd;
struct mdstat_ent *mdstat;
char *adev;
@ -2292,7 +2292,8 @@ int reshape_container(char *container, char *devname,
if (rv)
break;
}
unfreeze(st);
if (!rv)
unfreeze(st);
sysfs_free(cc);
exit(0);
}