Grow: check if any changes needed before proceeding to analyse_change.

Analyse_change can give unhelpful error messages if nothing was
changed.  This is particularly awkward when only changing --size.

So check and re-introduce a message that was list in commit
5da9ab9874

Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
NeilBrown 2011-05-10 11:49:57 +10:00
parent d1537ed192
commit d515d27f60
1 changed files with 12 additions and 0 deletions

12
Grow.c
View File

@ -1496,6 +1496,18 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
size = array.size;
}
/* See if there is anything else to do */
if ((level == UnSet || level == array.level) &&
(layout_str == NULL) &&
(chunksize == 0 || chunksize == array.chunk_size) &&
(raid_disks == 0 || raid_disks == array.raid_disks)) {
/* Nothing more to do */
if (!changed && !quiet)
fprintf(stderr, Name ": %s: no change requested\n",
devname);
goto release;
}
/* ========= check for Raid10/Raid1 -> Raid0 conversion ===============
* current implementation assumes that following conditions must be met:
* - RAID10: