Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

imsm: FIX: Do not allow for spare disk activation during reshape 

Spare disk activation or starting repair for one array while on second
reshape is in progress, will lead to IMSM incompatible situation when
2 arrays in container shares different disks sets.
This can cause that 2 processes in container /reshape and rebuild/
are in progress in parallel. This is IMSM incompatible situation also.

Block spare disk activation and starting resync if any reshape in container
is in progress.

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
Adam Kwolek 2011-10-03 10:30:28 +11:00 committed by NeilBrown
parent f211a13788
commit e2962bfc21
1 changed files with 27 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
super-intel.c
View File

@ -2237,6 +2237,31 @@ static int write_imsm_migr_rec(struct supertype *st)
}
#endif /* MDASSEMBLE */
/* spare/missing disks activations are not allowe when
* array/container performs reshape operation, because
* all arrays in container works on the same disks set
*/
int imsm_reshape_blocks_arrays_changes(struct intel_super *super)
{
int rv = 0;
struct intel_dev *i_dev;
struct imsm_dev *dev;
/* check whole container
*/
for (i_dev = super->devlist; i_dev; i_dev = i_dev->next) {
dev = i_dev->dev;
if (dev->vol.migr_state &&
dev->vol.migr_type == MIGR_GEN_MIGR) {
/* No repair during any migration in container
*/
rv = 1;
break;
}
}
return rv;
}
static void getinfo_super_imsm_volume(struct supertype *st, struct mdinfo *info, char *dmap)
{
struct intel_super *super = st->sb;
@ -6592,10 +6617,8 @@ static struct mdinfo *imsm_activate_spare(struct active_array *a,
dprintf("imsm: activate spare: inst=%d failed=%d (%d) level=%d\n",
inst, failed, a->info.array.raid_disks, a->info.array.level);
if (dev->vol.migr_state &&
dev->vol.migr_type == MIGR_GEN_MIGR)
/* No repair during migration */
return NULL;
if (imsm_reshape_blocks_arrays_changes(super))
return NULL;
if (a->info.array.level == 4)
/* No repair for takeovered array