Detail.c: do not skip first character when calling xstrdup in Detail()
'Commitb9c9bd9bac
("Detail: ensure --export names are acceptable as shell variables")' duplicates mdi->sys_name to sysdev string by, char *sysdev = xstrdup(mdi->sys_name + 1); which skips the first character of mdi->sys_name. Then when running mdadm --detail <md device> --export, the output looks like, MD_DEVICE_ev_sda2_ROLE=1 MD_DEVICE_ev_sda2_DEV=/dev/sda2 The first character of md device (between MD_DEVICE and _ROLE/_DEV) is dropped. The expected output should be, MD_DEVICE_dev_sda2_ROLE=1 MD_DEVICE_dev_sda2_DEV=/dev/sda2 This patch removes the '+ 1' from calling xstrdup() in Detail(), which gets the dropped first character back. Reported-by: Arvin Schnell <aschnell@suse.com> Fixes:b9c9bd9bac
("Detail: ensure --export names are acceptable as 4 shell variables") Signed-off-by: Coly Li <colyli@suse.de> Cc: NeilBrown <neilb@suse.com> Signed-off-by: Jes Sorensen <jsorensen@fb.com>
This commit is contained in:
parent
ebf3be9931
commit
e3615ecb5b
2
Detail.c
2
Detail.c
|
@ -284,7 +284,7 @@ int Detail(char *dev, struct context *c)
|
||||||
struct mdinfo *mdi;
|
struct mdinfo *mdi;
|
||||||
for (mdi = sra->devs; mdi; mdi = mdi->next) {
|
for (mdi = sra->devs; mdi; mdi = mdi->next) {
|
||||||
char *path;
|
char *path;
|
||||||
char *sysdev = xstrdup(mdi->sys_name + 1);
|
char *sysdev = xstrdup(mdi->sys_name);
|
||||||
char *cp;
|
char *cp;
|
||||||
|
|
||||||
path = map_dev(mdi->disk.major,
|
path = map_dev(mdi->disk.major,
|
||||||
|
|
Loading…
Reference in New Issue