Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Allow --incremental to add spares to an array. 

Commit 3a6ec29ad5 stopped us from adding apparently-working devices
to an active array with --incremental as there is a good chance that they
are actually old/failed devices.

Unfortunately it also stopped spares from being added to an active
array, which is wrong.  This patch refines the test to be more
careful.

Reported-by: <fibreraid@gmail.com>
Analysed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
NeilBrown 2010-08-12 11:41:41 +10:00
parent 172356c93a
commit ef83fe7cba
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Incremental.c
View File

@ -370,14 +370,15 @@ int Incremental(char *devname, int verbose, int runstop,
else
strcpy(chosen_name, devnum2devname(mp->devnum));
/* It is generally not OK to add drives to a running array
* as they are probably missing because they failed.
* However if runstop is 1, then the array was possibly
* started early and our best be is to add this anyway.
* It would probably be good to allow explicit policy
* statement about this.
/* It is generally not OK to add non-spare drives to a
* running array as they are probably missing because
* they failed. However if runstop is 1, then the
* array was possibly started early and our best be is
* to add this anyway. It would probably be good to
* allow explicit policy statement about this.
*/
if (runstop < 1) {
if ((info.disk.state & (1<<MD_DISK_SYNC)) != 0
&& runstop < 1) {
int active = 0;
if (st->ss->external) {