From feeb2785e67f084cb5d706fe5f074ade50bece78 Mon Sep 17 00:00:00 2001 From: Mateusz Kusiak Date: Thu, 12 Aug 2021 13:48:48 +0200 Subject: [PATCH] Utils: Change sprintf to snprintf Using sprintf can cause segmentation fault by exceeding the size of buffer array. Signed-off-by: Mateusz Kusiak Signed-off-by: Jes Sorensen --- util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util.c b/util.c index cdf1da2..ea07277 100644 --- a/util.c +++ b/util.c @@ -947,12 +947,12 @@ dev_t devnm2devid(char *devnm) /* First look in /sys/block/$DEVNM/dev for %d:%d * If that fails, try parsing out a number */ - char path[100]; + char path[PATH_MAX]; char *ep; int fd; int mjr,mnr; - sprintf(path, "/sys/block/%s/dev", devnm); + snprintf(path, sizeof(path), "/sys/block/%s/dev", devnm); fd = open(path, O_RDONLY); if (fd >= 0) { char buf[20];