Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't allow spares when creating 'external' arrays. 

It is meaningless when creating the container, and for
subarrays, the container is responsible for assigning
spares.

Also, don't do the 'spare' fiddle for raid5 as we cannot
set up a spare at this point yet.  Later maybe just create
the array degraded and let the container sort it out.
This commit is contained in:
NeilBrown 2008-09-18 16:03:08 +10:00
parent c5afc314e2
commit ffcfc735a5
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Create.c
View File

@ -166,6 +166,12 @@ int Create(struct supertype *st, char *mddev, int mdfd,
devlist = NULL;
}
}
if (st && st->ss->external && sparedisks) {
fprintf(stderr,
Name ": This metadata type does not support "
"spare disks are create time\n");
return 1;
}
if (subdevs > raiddisks+sparedisks) {
fprintf(stderr, Name ": You have listed more devices (%d) than are in the array(%d)!\n", subdevs, raiddisks+sparedisks);
return 1;
@ -411,6 +417,7 @@ int Create(struct supertype *st, char *mddev, int mdfd,
* into a spare, else the create will fail
*/
if (assume_clean == 0 && force == 0 && first_missing < raiddisks &&
st->ss->external == 0 &&
second_missing >= raiddisks && level == 6) {
insert_point = raiddisks - 1;
if (insert_point == first_missing)