mdadm/systemd
Coly Li 52c67fcdd6 mdadm/systemd: remove KillMode=none from service file
For mdadm's systemd configuration, current systemd KillMode is "none" in
following service files,
- mdadm-grow-continue@.service
- mdmon@.service

This "none" mode is strongly againsted by systemd developers (see man 5
systemd.kill for "KillMode=" section), and is considering to remove in
future systemd version.

As systemd developer explained in disuccsion, the systemd kill process
is,
1. send the signal specified by KillSignal= to the list of processes (if
   any), TERM is the default
2. wait until either the target of process(es) exit or a timeout expires
3. if the timeout expires send the signal specified by FinalKillSignal=,
   KILL is the default

For "control-group", all remaining processes will receive the SIGTERM
signal (by default) and if there are still processes after a period f
time, they will get the SIGKILL signal.

For "mixed", only the main process will receive the SIGTERM signal, and
if there are still processes after a period of time, all remaining
processes (including the main one) will receive the SIGKILL signal.

From the above comment, currently KillMode=control-group is a proper
kill mode. Since control-gropu is the default kill mode, the fix can be
simply removing KillMode=none line from the service file, then the
default mode will take effect.

Signed-off-by: Coly Li <colyli@suse.de>
Cc: Benjamin Brunner <bbrunner@suse.com>
Cc: Franck Bui <fbui@suse.de>
Cc: Jes Sorensen <jes@trained-monkey.org>
Cc: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Cc: Neil Brown <neilb@suse.de>
Cc: Xiao Ni <xni@redhat.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
2022-04-06 09:34:56 -04:00
..
SUSE-mdadm_env.sh SUSE-mdadm_env.sh: handle MDADM_CHECK_DURATION 2019-11-12 15:37:35 -05:00
mdadm-grow-continue@.service mdadm/systemd: remove KillMode=none from service file 2022-04-06 09:34:56 -04:00
mdadm-last-resort@.service systemd: add %I to description of mdadm-last-resort services. 2017-11-01 17:24:40 -04:00
mdadm-last-resort@.timer systemd: add %I to description of mdadm-last-resort services. 2017-11-01 17:24:40 -04:00
mdadm.shutdown install: use BINDIR consistently to locate mdadm and mdmon 2014-05-22 17:13:02 +10:00
mdcheck_continue.service Remove the legacy whitespace 2020-02-24 16:06:20 -05:00
mdcheck_continue.timer mdcheck: when mdcheck_start is enabled, enable mdcheck_continue too. 2019-11-12 15:36:27 -05:00
mdcheck_start.service Remove the legacy whitespace 2020-02-24 16:06:20 -05:00
mdcheck_start.timer mdcheck: when mdcheck_start is enabled, enable mdcheck_continue too. 2019-11-12 15:36:27 -05:00
mdmon@.service mdadm/systemd: remove KillMode=none from service file 2022-04-06 09:34:56 -04:00
mdmonitor-oneshot.service Remove the legacy whitespace 2020-02-24 16:06:20 -05:00
mdmonitor-oneshot.timer Monitor: add system timer to run --oneshot periodically 2018-12-06 07:44:57 -05:00
mdmonitor.service Move mdadm_env.sh out of /usr/lib/systemd 2017-10-10 16:45:04 -04:00