Martchus
/
pianobooster
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,392 Commits 7 Branches 12 Tags 38 MiB
Commit Graph

1392 Commits

Author SHA1 Message Date
Capitaine Fab 73f9e67c4a
Merge pull request #323 from pianobooster/martchus/code-modernization 
Martchus/code modernization
 2023-01-16 23:18:32 +01:00
Martchus 0cd1b38c8a Add myself in license and about dialog 2023-01-16 23:12:31 +01:00
Martchus 2604e3d9b2 Remove unused includes from `QtMain.cpp` 2023-01-16 23:12:31 +01:00
Martchus bd3cdf3e08 Use QStringLiteral for application meta-data string literals 2023-01-16 23:12:31 +01:00
Martchus e74818a7a3 Fix displaying application icon under Wayland 2023-01-16 23:12:31 +01:00
Martchus 4b921a55bb Avoid unnecessary copies when passing strings 2023-01-16 23:12:31 +01:00
Martchus 3401ef5ab4 Modernize coding style a little bit 
* Use QStringLiteral/QStringBuilder in a few places where it makes sense
* Remove unused variables
* Remove `== true`
* Specify context object when registering lambda as callback
 2023-01-16 23:11:16 +01:00
Capitaine Fab b19e3798b7
Merge pull request #322 from pianobooster/martchus/build-improvements 
Martchus/build improvements
 2023-01-16 23:06:44 +01:00
Jean Pierre Cimalando 921228381c Add the library paths of RtMidi 2023-01-16 22:59:42 +01:00
Martchus a890b1b673 Avoid CMake warning about OpenGL, prefer GLVND 2023-01-16 22:56:28 +01:00
Capitaine Fab 863c265f5e
Merge pull request #321 from pianobooster/martchus/migrate-to-qt6 
Martchus/migrate to qt6
 2023-01-16 22:52:37 +01:00
Fabien Givors 1903107766 Update BUILD.md & CI for Qt6 2023-01-16 22:52:23 +01:00
Martchus eb00f18b0c Port to Qt 6 2023-01-16 21:14:03 +01:00
Capitaine Fab ac4381a75a
Merge pull request #320 from pianobooster/martchus/code-quality 
Martchus/code quality
 2023-01-16 21:10:16 +01:00
Fabien Givors dffb0dd29b fix: xcode complains about auto return type 2023-01-16 21:05:37 +01:00
Martchus 540294593c Restore compatibility with GCC 7.5.0 
This old compiler version (which is still used in the CI) apparently runs
into the following error:
```
CMakeFiles/pianobooster.dir/QtWindow.o: In function `QtWindow::updateRecentFileActions()':
QtWindow.cpp:(.text+0x4bd2): undefined reference to `QtWindow::MAX_RECENT_FILES'
```
Using a function should workaround this problem.
 2023-01-16 20:48:00 +01:00
Martchus f8d26cf5f8 Restore compatibility with FluidSynth < 2.2 2023-01-16 20:41:04 +01:00
Martchus 8fa59cbec1 Keep compatibility with Qt < 5.11 2023-01-16 20:38:32 +01:00
Martchus 3948644150 Fix several warnings 
* Avoid many implicit type conversions or make them at least explicit
    * Use range-based for loops instead of an explicit index where possible
      to eliminate the problematic variable/comparison completely
    * Use float literals to avoid implicit conversions to double (and then
      back to float)
    * Replace some macros with constexpr functions that return the correct
      type
* Port away from deprecated FluidSynth and Qt classes and functions, most
  notably:
    * Use QElapsedTimer instead of QTime and change the type used to store
      ticks to qint64 accordingly
* Declare unused functions parameters as such explicitly to silence related
  warnings
 2023-01-16 20:07:08 +01:00
Martchus 642f85802e Allow enabling warnings via CMake cache variable 2023-01-16 20:07:08 +01:00
Capitaine Fab 088373394e
Merge pull request #318 from pianobooster/qopglwidget-migration 
QT5 QOpGLWidget migration
 2023-01-16 20:02:56 +01:00
Martchus 639ba3fc09 Revert special version-suffix for switch to QOpenGLWidget 2023-01-16 19:57:58 +01:00
Martchus e7d964fac4 Fix multisampling and alignment issues after switch to QOpenGLWidget 
* Implement `renderText()` more closely to Qt's version
* Add "+ 4" hack (see comment in code) to workaround alignment issue
* Fix scaling issues (`dpr` must be `qreal` and not `int` as it is in Qt's
  implementation, otherwise it breaks when using fractional scaling
  factors)
 2023-01-16 19:57:58 +01:00
Martchus 11101bbe91 Fix most important issues issues with using QOpenGLWidget 
* Fix constructing QColor when rendering text
* Port code using QGLFormat to use QSurfaceFormat
 2023-01-16 19:57:58 +01:00
louis-barman 25caf8306f Upgrading to use QOpenGLWidget instead of the obsolete QGLWidget in QT5 
This is Work In Progress (WIP)
 2023-01-16 19:57:58 +01:00
Capitaine Fab a127861b21
Merge pull request #319 from pianobooster/captnfab/fix-ci 
Captnfab/fix ci
 2023-01-16 19:51:01 +01:00
Fabien Givors c2c4bb11c6 Fix: CI: help cmake to find readline 2023-01-16 19:47:28 +01:00
Fabien Givors 6960d6c957 Fix: no double CI on push to pull-request 2023-01-16 19:47:28 +01:00
Fabien Givors e59cdac3bd CI: update brew package name 2023-01-16 19:47:28 +01:00
Fabien Givors 958f2303ad CI: do not upgrade all brew, just install dependencies 2023-01-16 19:47:28 +01:00
Fabien Givors f038df774d CI: bump macos version to 11 since 10.15 reached EOL 2023-01-16 19:47:28 +01:00
Martchus 92f868d50e Restore compatibility with FluidSynth < 2 
This should fix the error
```
/usr/include/fluidsynth/settings.h:213:6: note:   initializing argument 3 of ‘void fluid_settings_foreach(fluid_settings_t*, void*, fluid_settings_foreach_t)’
 void fluid_settings_foreach(fluid_settings_t* settings, void* data,
```
we see in the CI runs that are conducted under Ubuntu 18.04 (which is still
the oldest supported LTS Ubuntu so I refrain from simply bumping the Ubuntu
version used in the CI).
 2023-01-16 19:47:28 +01:00
louis-barman c8c2f5248c
Merge pull request #286 from Martchus/anti-aliasing 
Allow enabling MXAA
 2021-05-20 12:38:27 +01:00
Martchus 14f4204f70 Enable MXAA by default with an opt-out via a config file setting 2021-03-27 19:26:08 +01:00
louis-barman 4f385560f0 On MacOS it should be "portaudio" (not "pluseaudio) 2021-03-27 14:36:10 +00:00
louis-barman a9e0809a82 Added fluidsynth fixes for macOS and added fluidsynth debug logs. 2021-03-21 12:36:47 +00:00
louis-barman f57ccb310a
Merge pull request #283 from weblate/weblate-pianobooster-pianobooster 
Translations update from Weblate
 2021-02-22 22:43:29 +00:00
Milo Ivir 5742a4d2bc Translated using Weblate (Croatian) 
Currently translated at 40.2% (151 of 375 strings)

Translation: PianoBooster/PianoBooster
Translate-URL: https://hosted.weblate.org/projects/pianobooster/pianobooster/hr/
 2021-02-17 21:50:29 +01:00
louis-barman 74f59d0052
Merge pull request #282 from freddii/develop 
fixed typos
 2021-01-26 21:17:41 +00:00
louis-barman 6207bc563e
Merge pull request #280 from caseyavila/develop 
Update music sources reference
 2021-01-26 21:16:55 +00:00
louis-barman 4a711444d7
Merge pull request #279 from weblate/weblate-pianobooster-pianobooster 
Translations update from Weblate
 2021-01-26 21:15:58 +00:00
Backscale d6c8686a04
Translated using Weblate (Greek) 
Currently translated at 44.0% (165 of 375 strings)

Translation: PianoBooster/PianoBooster
Translate-URL: https://hosted.weblate.org/projects/pianobooster/pianobooster/el/
 2021-01-24 10:32:15 +01:00
freddii 446f5808f9 fixed typos 2021-01-24 00:04:39 +01:00
Jonatan Nyberg 12a05ebb2a
Translated using Weblate (Swedish) 
Currently translated at 88.2% (331 of 375 strings)

Translation: PianoBooster/PianoBooster
Translate-URL: https://hosted.weblate.org/projects/pianobooster/pianobooster/sv/
 2021-01-11 19:32:16 +01:00
Allan Nordhøy 25d3156b41
Translated using Weblate (Norwegian Bokmål) 
Currently translated at 78.1% (293 of 375 strings)

Translation: PianoBooster/PianoBooster
Translate-URL: https://hosted.weblate.org/projects/pianobooster/pianobooster/nb_NO/
 2021-01-11 19:32:15 +01:00
Luca De Filippo 48afae7ba3
Translated using Weblate (Italian) 
Currently translated at 99.7% (374 of 375 strings)

Translation: PianoBooster/PianoBooster
Translate-URL: https://hosted.weblate.org/projects/pianobooster/pianobooster/it/
 2021-01-11 19:32:15 +01:00
phrunk 584c085461
Translated using Weblate (German) 
Currently translated at 100.0% (375 of 375 strings)

Translation: PianoBooster/PianoBooster
Translate-URL: https://hosted.weblate.org/projects/pianobooster/pianobooster/de/
 2021-01-11 19:32:14 +01:00
Casey Avila a95d01f35a
Update music sources reference 2021-01-07 22:06:05 -08:00
Jonatan Nyberg 6a4d0a61fc
Translated using Weblate (Swedish) 
Currently translated at 71.4% (268 of 375 strings)

Translation: PianoBooster/PianoBooster
Translate-URL: https://hosted.weblate.org/projects/pianobooster/pianobooster/sv/
 2021-01-05 09:29:18 +01:00
Yaron Shahrabani 2ec5015eff Translated using Weblate (Hebrew) 
Currently translated at 28.0% (105 of 375 strings)

Translation: PianoBooster/PianoBooster
Translate-URL: https://hosted.weblate.org/projects/pianobooster/pianobooster/he/
 2020-12-18 22:29:14 +01:00