From 5bb72dfe5dc063ceec0b0617246bd3d86a64bfe8 Mon Sep 17 00:00:00 2001
From: Andrew Rabert <6550543+nvllsvm@users.noreply.github.com>
Date: Wed, 4 Jul 2018 02:42:29 -0400
Subject: [PATCH] docker: Add configurable UID and GID (#5041)

Allows for configuring the UID and GID Syncthing runs as in the container. Uses su-exec from the Alpine repos to accomplish this. Addition of su-exec results in <2MB increase in image size.
---
 Dockerfile       | 12 ++++++------
 README-Docker.md |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index 0a0ea5ab4..08acaa041 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -18,15 +18,15 @@ RUN apk add --no-cache ca-certificates
 
 COPY --from=builder /go/src/github.com/syncthing/syncthing/syncthing /bin/syncthing
 
-RUN echo 'syncthing:x:1000:1000::/var/syncthing:/sbin/nologin' >> /etc/passwd \
-    && echo 'syncthing:!::0:::::' >> /etc/shadow \
-    && chown syncthing /var/syncthing
+RUN apk update \
+    && apk add su-exec
 
-USER syncthing
 ENV STNOUPGRADE=1
+ENV PUID=1000
+ENV PGID=1000
 
 HEALTHCHECK --interval=1m --timeout=10s \
   CMD nc -z localhost 8384 || exit 1
 
-ENTRYPOINT ["/bin/syncthing", "-home", "/var/syncthing/config", "-gui-address", "0.0.0.0:8384"]
-
+ENTRYPOINT chown $PUID:$PGID /var/syncthing \
+    && su-exec $PUID:$PGID /bin/syncthing -home /var/syncthing/config -gui-address 0.0.0.0:8384
diff --git a/README-Docker.md b/README-Docker.md
index fc6504ccd..4e8516358 100644
--- a/README-Docker.md
+++ b/README-Docker.md
@@ -11,8 +11,8 @@ The exposed volumes are by default:
 
 You can add more folders and map them as you prefer.
 
-Note that Syncthing runs as UID 1000 in the container. This UID must have
-permission to read and modify the files in the containers.
+Note that Syncthing runs as UID 1000 and GID 1000 by default. These may be
+altered with the ``PUID`` and ``PGID`` environment variables.
 
 Example usage: