From b253022a968e1b444e832040e5ce34809aa0e5a9 Mon Sep 17 00:00:00 2001 From: Jakob Borg Date: Fri, 20 Nov 2020 17:43:59 +0100 Subject: [PATCH] build: Take extra tags in account for tar, zip --- build.go | 42 ++++++++++++++++++++---------------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/build.go b/build.go index 6476847b6..cc23c92dc 100644 --- a/build.go +++ b/build.go @@ -278,22 +278,18 @@ func main() { } func runCommand(cmd string, target target) { + var tags []string + if noupgrade { + tags = []string{"noupgrade"} + } + tags = append(tags, strings.Fields(extraTags)...) + switch cmd { case "install": - var tags []string - if noupgrade { - tags = []string{"noupgrade"} - } - tags = append(tags, strings.Fields(extraTags)...) install(target, tags) metalintShort() case "build": - var tags []string - if noupgrade { - tags = []string{"noupgrade"} - } - tags = append(tags, strings.Fields(extraTags)...) build(target, tags) case "test": @@ -321,10 +317,10 @@ func runCommand(cmd string, target target) { transifex() case "tar": - buildTar(target) + buildTar(target, tags) case "zip": - buildZip(target) + buildZip(target, tags) case "deb": buildDeb(target) @@ -539,14 +535,15 @@ func appendParameters(args []string, tags []string, pkgs ...string) []string { return append(args, pkgs...) } -func buildTar(target target) { +func buildTar(target target, tags []string) { name := archiveName(target) filename := name + ".tar.gz" - var tags []string - if noupgrade { - tags = []string{"noupgrade"} - name += "-noupgrade" + for _, tag := range tags { + if tag == "noupgrade" { + name += "-noupgrade" + break + } } build(target, tags) @@ -562,14 +559,15 @@ func buildTar(target target) { fmt.Println(filename) } -func buildZip(target target) { +func buildZip(target target, tags []string) { name := archiveName(target) filename := name + ".zip" - var tags []string - if noupgrade { - tags = []string{"noupgrade"} - name += "-noupgrade" + for _, tag := range tags { + if tag == "noupgrade" { + name += "-noupgrade" + break + } } build(target, tags)