From fbb7685f4b923c91b04315d1324503804d3c9716 Mon Sep 17 00:00:00 2001
From: Martchus <martchus@gmx.net>
Date: Tue, 18 May 2021 00:05:13 +0200
Subject: [PATCH] Fix warnings about detatching Qt container via for loop

---
 connector/syncthingconnection_requests.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/connector/syncthingconnection_requests.cpp b/connector/syncthingconnection_requests.cpp
index b2f6498..d6fd6aa 100644
--- a/connector/syncthingconnection_requests.cpp
+++ b/connector/syncthingconnection_requests.cpp
@@ -857,8 +857,9 @@ void SyncthingConnection::readErrors()
             return;
         }
 
-        for (const QJsonValueRef errorVal : replyDoc.object().value(QLatin1String("errors")).toArray()) {
-            const QJsonObject errorObj(errorVal.toObject());
+        const auto errors = replyDoc.object().value(QLatin1String("errors")).toArray();
+        for (const QJsonValue &errorVal : errors) {
+            const QJsonObject errorObj = errorVal.toObject();
             if (errorObj.isEmpty()) {
                 continue;
             }
@@ -1959,7 +1960,8 @@ void SyncthingConnection::readFolderErrors(DateTime eventTime, const QJsonObject
     dirInfo.itemErrors.clear();
 
     // add errors
-    for (const QJsonValueRef errorVal : eventData.value(QLatin1String("errors")).toArray()) {
+    const auto errors = eventData.value(QLatin1String("errors")).toArray();
+    for (const QJsonValue &errorVal : errors) {
         const QJsonObject error(errorVal.toObject());
         if (error.isEmpty()) {
             continue;