diff --git a/README.md b/README.md index 1580c14..9ef2a32 100644 --- a/README.md +++ b/README.md @@ -50,6 +50,10 @@ The GUI should be self-explaining. Just open a file, edit the tags and save the You can set the behaviour of the editor to keep previous values, so you don't have to enter information like album name or artist for all files in an album again and again. +#### Screenshots +##### Main window under Openbox/qt5ct with Breeze theme/icons +![main window/Openbox/qt5ct/Breeze](/resources/screenshots/mainwindow.png?raw=true) + #### Settings Checkout the settings dialog. You can: - customize which fields the editor shows and in which order @@ -163,7 +167,7 @@ Here are some Bash examples which illustrate getting and setting tag information The application depends on [c++utilities](https://github.com/Martchus/cpp-utilities) and [tagparser](https://github.com/Martchus/tagparser) and is built the same way as these libaries. For basic instructions checkout the README file of [c++utilities](https://github.com/Martchus/cpp-utilities). ### Building with Qt 5 GUI -The following Qt 5 modules are requried: core concurrent gui network declarative/script widgets webenginewidgets/webkitwidgets +The following Qt 5 modules are requried: core concurrent gui network widgets declarative/script webenginewidgets/webkitwidgets #### Select Qt modules for JavaScript and WebView * If Qt Script is installed on the system, the editor will link against it. Otherwise it will link against Qt QML. @@ -180,13 +184,13 @@ To build without GUI, add the following parameters to the CMake call: ``` ## TODO -- Support more formats (EXIF, PDF metadata, Theora in Ogg, ...). -- Allow adding tags to specific streams when dealing with Ogg. -- Do tests with Matroska files which have multiple segments. -- Set tag information concurrently if multiple files have been specified (CLI). +- Support more formats (EXIF, PDF metadata, Theora in Ogg, ...) +- Allow adding tags to specific streams when dealing with Ogg +- Do tests with Matroska files which have multiple segments +- Set tag information concurrently if multiple files have been specified (CLI) +- Support building in cue-sheet in flac ## Bugs -- Large file information is not shown when using Qt WebEngine. -- It is recommend you to create backups before editing because I can not test whether the - library works with all kind of files. If you force rewriting a backup is always created. +- Large file information is not shown when using Qt WebEngine +- It is recommend you to create backups before editing because I can not test whether the library works with all kind of files (when forcing rewrite a backup is always created) - underlying library: Matroska files composed of more than one segment aren't tested yet and might not work. diff --git a/dbquery/dbquery.cpp b/dbquery/dbquery.cpp index efb090f..73d7161 100644 --- a/dbquery/dbquery.cpp +++ b/dbquery/dbquery.cpp @@ -395,10 +395,9 @@ void MusicBrainzResultsModel::parseResults(QNetworkReply *reply, const QByteArra m_results.clear(); m_reader.addData(data); + // parse XML tree #define xmlReader m_reader #include - - // parse XML tree children { iftag("metadata") { children { @@ -481,7 +480,6 @@ void MusicBrainzResultsModel::parseResults(QNetworkReply *reply, const QByteArra } } else_skip } - #include // check for parsing errors diff --git a/gui/renamefilesdialog.cpp b/gui/renamefilesdialog.cpp index 76c2366..5c6ce97 100644 --- a/gui/renamefilesdialog.cpp +++ b/gui/renamefilesdialog.cpp @@ -19,6 +19,7 @@ #include #include #include +#include using namespace Dialogs; using namespace RenamingUtility; @@ -39,9 +40,7 @@ RenameFilesDialog::RenameFilesDialog(QWidget *parent) : setStyleSheet(dialogStyle() + QStringLiteral("QSplitter:handle { background-color: palette(base); }")); #endif // setup javascript editor and script file selection - QFont font(QStringLiteral("Courier"), 10); - font.setFixedPitch(true); - m_ui->javaScriptPlainTextEdit->setFont(font); + m_ui->javaScriptPlainTextEdit->setFont(QFontDatabase::systemFont(QFontDatabase::FixedFont)); m_highlighter = new JavaScriptHighlighter(m_ui->javaScriptPlainTextEdit->document()); m_ui->externalScriptPage->setBackgroundRole(QPalette::Base); diff --git a/translations/tageditor_de_DE.ts b/translations/tageditor_de_DE.ts index d23aca3..81075f9 100644 --- a/translations/tageditor_de_DE.ts +++ b/translations/tageditor_de_DE.ts @@ -726,27 +726,27 @@ - + Insufficient search criteria supplied - + Retrieving meta data ... - + Aborted - + No results available - + %1 result(s) available @@ -754,22 +754,22 @@ - + Retrieving cover art to be applied ... - + Show cover - + Retrieving cover art ... - + Cover - %1 @@ -1897,58 +1897,58 @@ another position would prevent rewriting the entire file - + No file opened. - + A tag editing utility supporting ID3, MP4 (iTunes style), Vorbis and Matroska tags. - + Unable to show the next file because it can't be found anymore. - + Open file - - + Save changes as - - + Save file information - - + No file is opened. - + Unable to save file information because the current process hasn't been finished yet. - + Unable to write to file. %1 - + Unable to open file. - + No file information available. @@ -2369,8 +2369,8 @@ another position would prevent rewriting the entire file - - + + Close @@ -2390,8 +2390,8 @@ another position would prevent rewriting the entire file - - + + Abort @@ -2422,43 +2422,43 @@ another position would prevent rewriting the entire file - + from file - + from clipboard - + default script - + Generating preview ... - + The script is not valid. Error in line %1: %3 - + The selected directory doesn't exist. - + Applying changings ... - + %1 files/directories processed @@ -2466,13 +2466,13 @@ Error in line %1: %3 - + Preview has been generated. - - + + %1 error(s) occured. @@ -2480,8 +2480,8 @@ Error in line %1: %3 - - + + %1 files/directories have been processed. @@ -2489,12 +2489,12 @@ Error in line %1: %3 - + No files and directories have been found. - + %1 error(s) occured @@ -2502,62 +2502,62 @@ Error in line %1: %3 - + There is no external script file is selected. - + Unable to open external script file. - + An error occured when parsing the script: %1 - + The script is empty. - + Generation of preview has been aborted prematurely. - + Changins applied. - + Applying has been aborted prematurely. - + Unable to open script file. - + Select script - + Clipboard contains no text. - + Expand all - + Collapse all @@ -2595,12 +2595,12 @@ Error in line %1: %3 - + with different targets - + targeting %1 @@ -2673,7 +2673,7 @@ the file reverting all unsaved changings. - + Abort @@ -2753,199 +2753,199 @@ the file reverting all unsaved changings. - + Segment %1 - + Attachments - + Matroska tag - + MP4/iTunes tag - - + + Vorbis comment - + Tag - + ID3v1 tag - + ID3v2 tag - - + + Copy - + Unable to load the selected file "%1" because the current process hasn't finished yet. - + The file is beeing parsed ... - + Unable to reload the file because the current process hasn't finished yet. - + Currently is not file opened. - + The file could not be opened because an IO error occurred. - + File could be parsed correctly. - + File couldn't be parsed correctly. - + There are critical parsing notifications. - + There are warnings. - + There is no (supported) tag assigned. - + File format is not supported (an ID3 tag can be added anyways). - + The file %1 has been opened. - + Unable to apply the entered tags to the file because the current process hasn't finished yet. - + Saving tags ... - + No file has been opened. - + Unable to delete all tags from the file because the current process hasn't been finished yet. - + Do you really want to delete all tags from the file? - + don't show this message again - + Deleting all tags ... - + The selected file stores no tag (at least no supported), so there is nothing to delete. - + No file has been opened, so no tags can be deleted. - + Unable to start saving process because there an other process hasn't finished yet. - + Cancelling ... - + Expand all - + Collapse all - + Opening file - %1 - + Opening file: - + No write access; the file has been opened in read-only mode. - + The file is composed of multiple segments. Dealing with such files has not been tested yet and might be broken. - + The tags have been saved, but there is/are %1 warning(s) @@ -2953,7 +2953,7 @@ the file reverting all unsaved changings. - + and %1 error(s). @@ -2961,7 +2961,7 @@ the file reverting all unsaved changings. - + The tags have been saved, but there is/are %1 warning(s). @@ -2969,72 +2969,72 @@ the file reverting all unsaved changings. - + The tags have been saved. - + The tags couldn't be saved. See the info box for detail. - + The tags couldn't be saved because an IO error occured. - + Automatic tag management - + The container format of the selected file is not supported. The file can be treated as MP3 file (an ID3 tag according to the settings will be created). This might break the file. Do you want to continue? - + Treat file as MP3 file - + The currently opened file changed on the disk. - + A tag (with the selected target) already exists. - + The tag can not be created. - + Unable to remove the tag because the current process hasn't been finished yet. - + Unable to remove the tag because no file is opened. - + Unable to change the target because the current process hasn't been finished yet. - + Unable to change the target because no file is opened. - + Can not change the target of the selected tag because the tag does not support targets. @@ -4312,147 +4312,147 @@ Remarks - + Field - + Title - + Album - + Artist - + Genre - + Year - + Comment - + BPM - + BPS - + Lyricist - + Track - + Disk - + Part - + Total parts - + Encoder - + Record date - + Performers - + Duration - + Language - + Encoder settings - + Lyrics - + Synchronized lyrics - + Grouping - + Record label - + Cover - + Composer - + Rating - + Description - + Vendor diff --git a/translations/tageditor_en_US.ts b/translations/tageditor_en_US.ts index 0f0e13f..01ba157 100644 --- a/translations/tageditor_en_US.ts +++ b/translations/tageditor_en_US.ts @@ -663,27 +663,27 @@ - + Insufficient search criteria supplied - + Retrieving meta data ... - + Aborted - + No results available - + %1 result(s) available %1 result available @@ -691,22 +691,22 @@ - + Retrieving cover art to be applied ... - + Show cover - + Retrieving cover art ... - + Cover - %1 @@ -1897,58 +1897,58 @@ another position would prevent rewriting the entire file - + No file opened. - + A tag editing utility supporting ID3, MP4 (iTunes style), Vorbis and Matroska tags. - + Unable to show the next file because it can't be found anymore. - + Open file - - + Save changes as - - + Save file information - - + Unable to write to file. %1 - + Unable to open file. - + No file information available. - + No file is opened. - + Unable to save file information because the current process hasn't been finished yet. @@ -2334,7 +2334,7 @@ another position would prevent rewriting the entire file - + %1 files/directories processed %1 file/directory processed @@ -2342,23 +2342,23 @@ another position would prevent rewriting the entire file - + Preview has been generated. - + No files and directories have been found. - + Generation of preview has been aborted prematurely. - - + + %1 error(s) occured. %1 error occured. @@ -2366,8 +2366,8 @@ another position would prevent rewriting the entire file - - + + %1 files/directories have been processed. %1 file/directory has been processed. @@ -2375,69 +2375,69 @@ another position would prevent rewriting the entire file - + from file - + from clipboard - + default script - + There is no external script file is selected. - + Unable to open external script file. - + Generating preview ... - - + + Abort - + The script is not valid. Error in line %1: %3 - + An error occured when parsing the script: %1 - + The script is empty. - + The selected directory doesn't exist. - + Applying changings ... - + %1 error(s) occured %1 error occured @@ -2445,37 +2445,37 @@ Error in line %1: %3 - + Changins applied. - + Applying has been aborted prematurely. - + Unable to open script file. - + Select script - + Clipboard contains no text. - + Expand all - + Collapse all @@ -2536,8 +2536,8 @@ Error in line %1: %3 - - + + Close @@ -2595,12 +2595,12 @@ Error in line %1: %3 - + with different targets - + targeting %1 @@ -2623,199 +2623,199 @@ Error in line %1: %3 - + Segment %1 - + Attachments - + Matroska tag - + MP4/iTunes tag - - + + Vorbis comment - + Tag - + ID3v1 tag - + ID3v2 tag - - + + Copy - + Expand all - + Collapse all - + The file is beeing parsed ... - + Unable to load the selected file "%1" because the current process hasn't finished yet. - + Currently is not file opened. - + Unable to reload the file because the current process hasn't finished yet. - + The file could not be opened because an IO error occurred. - + Opening file - %1 - + Opening file: - + File could be parsed correctly. - + File couldn't be parsed correctly. - + There are critical parsing notifications. - + There are warnings. - + No write access; the file has been opened in read-only mode. - + File format is not supported (an ID3 tag can be added anyways). - + The file is composed of multiple segments. Dealing with such files has not been tested yet and might be broken. - + There is no (supported) tag assigned. - + The file %1 has been opened. - + Saving tags ... - + No file has been opened. - + Unable to apply the entered tags to the file because the current process hasn't finished yet. - + Do you really want to delete all tags from the file? - + don't show this message again - + Deleting all tags ... - + The selected file stores no tag (at least no supported), so there is nothing to delete. - + No file has been opened, so no tags can be deleted. - + Unable to delete all tags from the file because the current process hasn't been finished yet. - + Cancelling ... - + Unable to start saving process because there an other process hasn't finished yet. - + The tags have been saved, but there is/are %1 warning(s) The tags have been saved, but there is %1 warning @@ -2823,7 +2823,7 @@ Error in line %1: %3 - + and %1 error(s). and %1 error. @@ -2831,7 +2831,7 @@ Error in line %1: %3 - + The tags have been saved, but there is/are %1 warning(s). The tags have been saved, but there is %1 warning. @@ -2839,72 +2839,72 @@ Error in line %1: %3 - + The tags have been saved. - + The tags couldn't be saved. See the info box for detail. - + The tags couldn't be saved because an IO error occured. - + Automatic tag management - + The container format of the selected file is not supported. The file can be treated as MP3 file (an ID3 tag according to the settings will be created). This might break the file. Do you want to continue? - + Treat file as MP3 file - + The currently opened file changed on the disk. - + A tag (with the selected target) already exists. - + The tag can not be created. - + Unable to remove the tag because no file is opened. - + Unable to remove the tag because the current process hasn't been finished yet. - + Unable to change the target because no file is opened. - + Can not change the target of the selected tag because the tag does not support targets. - + Unable to change the target because the current process hasn't been finished yet. @@ -2974,7 +2974,7 @@ the file reverting all unsaved changings. - + Abort @@ -4312,147 +4312,147 @@ Remarks - + Title - + Album - + Artist - + Genre - + Year - + Comment - + BPM - + BPS - + Lyricist - + Track - + Disk - + Part - + Total parts - + Encoder - + Record date - + Performers - + Duration - + Language - + Encoder settings - + Lyrics - + Synchronized lyrics - + Grouping - + Record label - + Cover - + Composer - + Rating - + Description - + Vendor - + Field