Martchus
/
tageditor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Avoid catchinng all exceptions without re-throwing them 

This shouldn't be required and leads to problems when `pthread_cancel`
would be used: https://udrepper.livejournal.com/21541.html

Note that the tagparser library itself does not contain any `catch (...)`
blocks (which do not re-throw).
This commit is contained in:
Martchus 2021-02-11 16:54:18 +01:00
parent 89a85184c3
commit e3eff819ec
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gui/tageditorwidget.cpp
View File

@ -862,9 +862,6 @@ bool TagEditorWidget::startParsing(const QString &path, bool forceRefresh)
} catch (const std::exception &e) {
diag.emplace_back(TagParser::DiagLevel::Critical, argsToString("Something completely unexpected happened: ", +e.what()), "parsing");
result = FatalParsingError;
} catch (...) {
diag.emplace_back(TagParser::DiagLevel::Critical, "Something completely unexpected happened", "parsing");
result = FatalParsingError;
}
QMetaObject::invokeMethod(this, "showFile", Qt::QueuedConnection, Q_ARG(char, result));
};
@ -1192,9 +1189,6 @@ bool TagEditorWidget::startSaving()
} catch (const exception &e) {
m_diag.emplace_back(TagParser::DiagLevel::Critical, argsToString("Something completely unexpected happened: ", e.what()), "making");
processingError = true;
} catch (...) {
m_diag.emplace_back(TagParser::DiagLevel::Critical, "Something completely unexpected happened", "making");
processingError = true;
}
QMetaObject::invokeMethod(
this, "showSavingResult", Qt::QueuedConnection, Q_ARG(bool, processingError), Q_ARG(bool, ioError), Q_ARG(bool, canceled));