Use the output file path when making an MP4 file also if no rewrite required
Otherwise the `--output-files` option of the tag editor will be ignored when editing an MP4 file and no rewrite is required. Note that the condition is already this way in `MediaFileInfo::makeMp3File()` and `MatroskaContainer::internalMakeFile()`.
This commit is contained in:
parent
766e7657b5
commit
04e6996ce3
|
@ -243,7 +243,7 @@ void Mp4Container::internalMakeFile(Diagnostics &diag, AbortableProgressFeedback
|
|||
// -> whether media data is written chunk by chunk (need to write chunk by chunk if tracks have been altered)
|
||||
const bool writeChunkByChunk = m_tracksAltered;
|
||||
// -> whether rewrite is required (always required when forced to rewrite or when tracks have been altered)
|
||||
bool rewriteRequired = fileInfo().isForcingRewrite() || writeChunkByChunk;
|
||||
bool rewriteRequired = fileInfo().isForcingRewrite() || writeChunkByChunk || !fileInfo().saveFilePath().empty();
|
||||
// -> use the preferred tag position/index position (force one wins, if both are force tag pos wins; might be changed later if none is forced)
|
||||
ElementPosition initialNewTagPos
|
||||
= fileInfo().forceTagPosition() || !fileInfo().forceIndexPosition() ? fileInfo().tagPosition() : fileInfo().indexPosition();
|
||||
|
|
Loading…
Reference in New Issue