overall code cleanup

aspectratio.h

@@ -41,7 +41,7 @@ inline AspectRatio::AspectRatio(uint16 numerator, uint16 denominator) :
  */
 inline bool AspectRatio::isValid() const
 {
-    return !type || !numerator || !denominator;
+    return type && numerator && denominator;
 }
 
 /*!

matroska/matroskacontainer.cpp

@@ -10,9 +10,7 @@
 #include "../backuphelper.h"
 
 // include configuration from separate header file when building with CMake
-#ifndef APP_METADATA_AVAIL
 #include "resources/config.h"
-#endif
 
 #include <c++utilities/conversion/stringconversion.h>
 #include <c++utilities/misc/memory.h>
@@ -58,9 +56,6 @@ MatroskaContainer::MatroskaContainer(MediaFileInfo &fileInfo, uint64 startOffset
     m_doctypeReadVersion = 1;
 }
 
-/*!
- * \brief Destroys the container.
- */
 MatroskaContainer::~MatroskaContainer()
 {}
 

mp4/mp4container.cpp

@@ -34,9 +34,6 @@ Mp4Container::Mp4Container(MediaFileInfo &fileInfo, uint64 startOffset) :
     m_fragmented(false)
 {}
 
-/*!
- * \brief Destroys the container.
- */
 Mp4Container::~Mp4Container()
 {}
 

ogg/oggcontainer.cpp

@@ -20,7 +20,7 @@ namespace Media {
  * \brief Constructs a new container for the specified \a stream at the specified \a startOffset.
  */
 OggContainer::OggContainer(MediaFileInfo &fileInfo, uint64 startOffset) :
-    GenericContainer<MediaFileInfo, VorbisComment, OggStream, OggPage>(fileInfo, startOffset),//AbstractContainer(stream, startOffset)
+    GenericContainer<MediaFileInfo, VorbisComment, OggStream, OggPage>(fileInfo, startOffset),
     m_iterator(fileInfo.stream(), startOffset, fileInfo.size()),
     m_validateChecksums(false)
 {}