Martchus
acfb9ef219
Handle TRACKTOTAL/DISCTOTAL/PARTTOTAL fields in Vorbis Comments
...
* Move those fields into their corresponding
TRACKNUMBER/DISCNUMBER/PARTNUMBER fields after parsing so they are
accessible via just one field as PositionInSet which is in line with
other tag formats and also how other software like VLC expect the total
to be specified
* NOT implemented yet: Move those fields optionally back into separate
fields when serializing
2024-02-28 21:36:06 +01:00
Martchus
92345027fb
Use generic `toInt()` function which relies less on compiler optimizations
2023-05-18 00:52:28 +02:00
Martchus
981db492e4
Avoid unqualified calls to `std::move`
2023-02-20 19:54:42 +01:00
Martchus
e40c1901e1
Fix crash when parsing FLAC header
2022-05-23 19:55:32 +02:00
Martchus
fd5e9bf950
Fix crashes due to wrong parameter passing
...
The refactoring to use `std::string_view`
(see 64d98f5530https://github.com/Martchus/tageditor/issues/75 ). We must specify the
size because the buffers used here are not null-terminated.
2021-10-26 15:54:30 +02:00
Martchus
0a041f6ad2
Fix warnings
2021-03-20 21:26:25 +01:00
Martchus
65597fd71e
Add API to allow aborting overall/expensive parsing functions
...
* Not really implemented within the various code paths of the parsers at
this point; this commit mainly adds the API.
* Adjust example in README
2021-02-04 23:21:50 +01:00
Martchus
64d98f5530
Use std::string_view where it makes sense
2021-01-30 21:53:06 +01:00
Martchus
761e3ee44b
Mark all "final" tag, track and container classes as such
2020-12-18 21:13:52 +01:00
Martchus
c9e1dde70b
Adapt to changes in c++utilities
2019-06-12 20:40:45 +02:00
Martchus
5ad00a083c
Adapt to changes in c++utilities
2019-06-10 23:11:39 +02:00
Martchus
7efa7a0d5a
Adapt to c++utilities v5
2019-05-04 16:04:21 +02:00
Martchus
e81c6bb169
Implement small TODOs for v8
2018-07-12 12:34:38 +02:00
Martchus
9361e0bc13
Use constexpr where possible
2018-07-12 12:34:38 +02:00
Martchus
3265e0bea4
Fix documentation which was still using the old namespace
2018-06-03 20:38:32 +02:00
Martchus
0a640c9f7f
Fix warnings, mostly about implicit int conversions
...
This should fix all non-erros, leaving only warnings which
are indeed potential problems.
The following warnings should be safe to ignore:
* Conversions of various offsets from uint64 to
std::streamoff/int64 are safe because such offsets have
been obtained via tellg() and other functions
returning std::streamoff in the first place.
* It also works vice-versa since tellg() should not
return negative offsets with exceptions enabled.
* Conversions from char to unsigned char are also ok.
* Unused diag arguments can be ignored (those might be
useful later).
* Annotate all intended fallthoughs.
2018-06-02 23:04:53 +02:00
Martchus
ce4bd73037
Fix setting "isLast" flag when making FLAC header
2018-04-29 21:14:28 +02:00
Martchus
9b83cc37f6
Handle case when Vorbis Comment exceeds max. size in FLAC stream
2018-04-29 19:45:20 +02:00
Martchus
c0336ed4bb
Apply clang-format
2018-03-07 01:17:50 +01:00
Martchus
a0986ad4a9
Fix style issues
2018-03-07 01:11:42 +01:00
Martchus
0e15c74103
Move everything into namespace TagParser
2018-03-06 23:09:15 +01:00
Martchus
36511fcc13
Add progress feedback and diagnostics replacing status provider
2018-03-06 22:44:01 +01:00
Martchus
c3394acdb2
Fix typos
2017-03-01 18:21:00 +01:00
Martchus
b97192abd3
Use std::make_unique provided by C++14
2017-02-05 21:02:40 +01:00
Martchus
d7ca2a0cd4
Warn about empty METADATA_BLOCK_PICTURE
2016-11-19 14:33:06 +01:00
Martchus
0cf30edbff
Fix decoration for static builds
2016-08-29 15:43:05 +02:00
Martchus
0dc6d59240
Calculate duration of FLAC streams
2016-05-22 22:27:36 +02:00
Martchus
53f0903c3b
Add tests for FLAC files
2016-05-21 22:11:08 +02:00
Martchus
a84ac37dbe
Add support for raw FLAC streams
2016-05-16 20:56:53 +02:00
Martchus
bbafd16dcc
Support FLAC in Ogg
2016-05-14 23:20:51 +02:00
Martchus