Commit Graph

517 Commits

Author SHA1 Message Date
Martchus f228e88c5e Update translations 2019-10-11 20:03:00 +02:00
Martchus 72e918b154 Remove debugging leftover 2019-10-11 19:55:45 +02:00
Martchus 4531d10a81 Move QJSEngine into the thread which executes the JavaScript
This fixes https://github.com/Martchus/tageditor/issues/50.

When keeping the QJSEngine tied to the main thread the garbage
collector will run on the main thread's event loop. This leads to
crashes when trying to allocate memory within the engine from
another thread (`QV4::PersistentValueStorage::allocate()`).

The Qt documentation does not mention that the garbage collector
might run on the event loop of the thread tied to the JSEngine.
I expected it only to run after or before allocations/deletions
within the thread calling the engine's methods. There is already
an issue regarding the lack of documentation:
https://bugreports.qt.io/browse/QTBUG-57227

I found no way to obtain the QThread object for a thread started
with Qt Concurrent. The possibility I found was calling
`QThread::currentThread()` from the concurrent thread once it has
already been started. However, when the concurrent thread has
been started it might already be too late to move the engine.
Adding further synchronization to solve this is an overkill so
I resorted to using QThread directly.
2019-10-11 19:47:30 +02:00
Martchus bf4687d0b6 Remove leftovers from old notification system in JS code
This change was made when already investigating https://github.com/Martchus/tageditor/issues/50.
So that issue was there before this change.
2019-10-08 18:55:08 +02:00
Martchus bdc1c0d8d9 Update version: 3.3.0 -> 3.3.1 2019-09-27 15:36:57 +02:00
Martchus d92814187a Hide progress indication before showing cover/lyrics dialog 2019-09-25 18:18:06 +02:00
Martchus dc4a6b2ee9 Make "...ApiUrl()" functions static 2019-09-25 18:17:08 +02:00
Martchus 2a9b7eb48a Make LyricsWikia query more robust
This PR adds a fallback to a self-crafted URL if the XML which is
supposed to contain it broken.

That's required because it seems that the XML is sometimes not
generated correctly (e.g. missing "+" character in song name which
has the plus sign in it).
2019-09-25 18:16:20 +02:00
Martchus 7f58124bf0 Use aboutToQuit() signal for cleanup-code
As recommended by the Qt documentation
2019-09-14 19:44:34 +02:00
Martchus 474d66b25c Improve db query widget
* Trigger auto-insert also when query results are available
* Allow to refresh when new search criteria has been (automatically)
  inserted

So it is at least a little bit more convenient to use.
2019-09-03 22:04:43 +02:00
Martchus 76ba02c3c0 Improve context menu of db query widget 2019-09-02 22:13:57 +02:00
Martchus 015dc06c17 Allow to query makeitpersonal.co for lyrics 2019-09-02 21:47:11 +02:00
Martchus a94f2e3675 Improve UI of db query widget
* Move query options into menu so it is possible to add more
  without being limited by available space
* Trigger the last query action when hitting the enter key
* Change order of elements; I guess it looks better with buttons
  and fields to be used at the top
2019-09-02 21:42:56 +02:00
Martchus d3f84c4c39 Add conversion from ISO-639-2/B codes to language names 2019-08-17 20:58:14 +02:00
Martchus a5224d930d Apply clang-format 2019-08-13 00:35:04 +02:00
Martchus aa0d57f56a Apply DB query row on double click 2019-08-12 20:27:51 +02:00
Martchus 9c16e22ca8 Ignore case when matching DB query row 2019-08-12 20:27:16 +02:00
Martchus 9a37492a10 Use helper for flag enum class from c++utilities 2019-08-12 20:26:38 +02:00
Martchus 9fd765c6de Set size policy of cover type selection to minimum expanding 2019-08-12 00:31:41 +02:00
Martchus 570bfc74ac Construct QList for pages from initializer list 2019-08-10 22:04:10 +02:00
Martchus 89ccc39d4b Remove use of fallback icons from qtutilities
Rely on icons from (bundled) icon theme instead.
2019-08-08 22:57:30 +02:00
Martchus 865b3501c4 Allow scaling and converting assigned covers 2019-07-21 23:46:46 +02:00
Martchus 955c497a52 Don't abuse organization domain for website in AboutDialog 2019-07-20 20:19:30 +02:00
Martchus 864fd1c901 Fix remaining context menus for Wayland 2019-07-20 18:49:32 +02:00
Martchus 46637093db Remove useless semicolon 2019-07-20 18:42:48 +02:00
Martchus 6c3a230962 Don't use QCursor::pos() for context menu position
It might now work under Wayland.
2019-07-20 18:42:32 +02:00
Martchus 7e83f7a919 Set project() on top-level
See https://github.com/Martchus/cpp-utilities/pull/15
2019-07-20 18:09:16 +02:00
Martchus 376b15a06e Fix warnings in TagEditorWidget::updateDocumentTitleEdits() 2019-07-20 17:59:18 +02:00
Martchus 8365c267d7 Update translations 2019-07-07 15:40:42 +02:00
Martchus ce0c0c9e19 Workaround lupdate issue 2019-07-07 15:39:24 +02:00
Martchus 72d31c568e Don't use functions obsoleted in Qt 5.13.0 2019-06-25 14:10:31 +02:00
Martchus 940deda0f3 Ensure Qt specific config is included 2019-06-16 15:55:55 +02:00
Martchus 94c77deb40 Only keep the last 20 cover images 2019-06-14 18:08:05 +02:00
Martchus 66a45f7578 Adapt to changes in c++utilities 2019-06-12 20:47:44 +02:00
Martchus 66c9250246 Adapt to changes in c++utilities 2019-06-10 22:49:46 +02:00
Martchus f70941a262 Increase minor version 2019-06-01 12:55:06 +02:00
Martchus 9d175ac316 Add info about automatic insertion from search results 2019-06-01 12:54:22 +02:00
Martchus cf71ac5dca Add info about auto-correction when opening file 2019-06-01 12:53:44 +02:00
Martchus ef82a88a97 Hide empty columns in db query widget 2019-06-01 12:51:11 +02:00
Martchus 52ab1d3f12 Use fromStdString()/toStdString() in AttachmentItem 2019-06-01 12:50:42 +02:00
Martchus 89e3e4b657 Support disk number in db query widget 2019-06-01 12:50:09 +02:00
Martchus de5bb26303 Apply cmake-format 0.5.1 2019-06-01 12:47:45 +02:00
Martchus 9edfa63e7f Use QString's characterset conversion functions when possible 2019-06-01 12:47:08 +02:00
Martchus 081fb816b5 Fix error in example renaming script 2019-06-01 12:45:52 +02:00
Martchus de558048ce Use override 2019-06-01 12:45:12 +02:00
Martchus 54315a3739 Use icons which are better distinguishable in file info 2019-06-01 12:40:02 +02:00
Martchus 72330988ef Ignore default.profraw 2019-06-01 12:36:48 +02:00
Martchus 34a1595641 Improve documentation 2019-05-31 14:02:11 +02:00
Martchus 208c90ef42 Require only one of title and track to match search results 2019-05-31 13:55:36 +02:00
Martchus d2a51ad473 Show all recording/release combinations from MusicBrainz 2019-05-31 13:54:16 +02:00