Martchus
/
mdadm
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

imsm: FIX: map coping causes mdmon crash 

Too big map was copied (outside allocated memory) and this causes
mdmon crash for 2 raid0 arrays in container.
Map of correct (smaller) size should be copied,
to not overwrite any internal data.

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
Adam Kwolek 2011-02-01 10:40:56 +11:00 committed by NeilBrown
parent 401d313b7f
commit 1dfaa38015
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
super-intel.c
View File

@ -5062,6 +5062,7 @@ static void imsm_progress_container_reshape(struct intel_super *super)
struct imsm_super *mpb = super->anchor;
int prev_disks = -1;
int i;
int copy_map_size;
for (i = 0; i < mpb->num_raid_devs; i++) {
struct imsm_dev *dev = get_imsm_dev(super, i);
@ -5082,6 +5083,7 @@ static void imsm_progress_container_reshape(struct intel_super *super)
* i.e it needs a migr_state
*/
copy_map_size = sizeof_imsm_map(map);
prev_num_members = map->num_members;
map->num_members = prev_disks;
dev->vol.migr_state = 1;
@ -5092,7 +5094,7 @@ static void imsm_progress_container_reshape(struct intel_super *super)
set_imsm_ord_tbl_ent(map, i, i);
map2 = get_imsm_map(dev, 1);
/* Copy the current map */
memcpy(map2, map, sizeof_imsm_map(map));
memcpy(map2, map, copy_map_size);
map2->num_members = prev_num_members;
/* calculate new size